On bug 37895 we have failed to propose a solution to encapsulate exceptions and rethrow them. Until this is ready we should not try/catch and so use say_failure from our DB revs.
Created attachment 174239 [details] [review] Bug 38394: Remove existing try/catch and say_failure from DB revs On bug 37895 we have failed to propose a solution to encapsulate exceptions and rethrow them. Until this is ready we should not try/catch and so use say_failure from our DB revs. We want to stop the DB update process when something is wrong. In those try/catch we are actually continuing even if something bad happens. As RaiseError is set on the dbh, say_failure statements will never be reached. Test plan: checkout origin/24.05.0 reset_all checkout main + this patch updatedatabase Everything should run fine.
Created attachment 174240 [details] [review] Bug 38394: Remove 3 'done' We don't want that, and it's not consistent with the other outputs. If we don't have anything useful to say, don't say anything.
I've removed say_failure from https://wiki.koha-community.org/wiki/Database_updates as well.
Reviewed carefully, going to push these.
btw, found some inconsistencies in the DB output * "Added OAI-PMH:HarvestEmailReport system preference" should be "Added new system preference 'OAI-PMH:HarvestEmailReport'" * Added new system preference 'JobsNotificationMethod' is white instead of green * Added column 'service_platformerm_usage_data_providers' is blue (why not green?) * "list_borrowers added to 1 users with manage_bookings" should be better worded, like "Added permissions 'permission' to ..." * "Added BOOKING_CANCELLATION authorised value category" should be "Added new authorised value category 'CAT'" * "Updated manage_search_targets permission description" => this is only noise
(In reply to Jonathan Druart from comment #5) > btw, found some inconsistencies in the DB output > > > * "Added OAI-PMH:HarvestEmailReport system preference" should be "Added new > system preference 'OAI-PMH:HarvestEmailReport'" > > * Added new system preference 'JobsNotificationMethod' is white instead of > green > > * Added column 'service_platformerm_usage_data_providers' is blue (why not > green?) > > * "list_borrowers added to 1 users with manage_bookings" should be better > worded, like "Added permissions 'permission' to ..." > > * "Added BOOKING_CANCELLATION authorised value category" should be "Added > new authorised value category 'CAT'" > > * "Updated manage_search_targets permission description" => this is only > noise I agree that these slipped through and I also corrected many before pushing already. Follow-up's woudl be very welcome.
Pushed for 24.11! Well done everyone, thank you!
Moved to Bug 38448 - Fix inconsistencies in database update messages