Moved from bug 38394: * "Added OAI-PMH:HarvestEmailReport system preference" should be "Added new system preference 'OAI-PMH:HarvestEmailReport'" * Added new system preference 'JobsNotificationMethod' is white instead of green * Added column 'service_platformerm_usage_data_providers' is blue (why not green?) * "list_borrowers added to 1 users with manage_bookings" should be better worded, like "Added permissions 'permission' to ..." * "Added BOOKING_CANCELLATION authorised value category" should be "Added new authorised value category 'CAT'" * "Updated manage_search_targets permission description" => this is only noise
I'm happy to have a go at this, if it is just a matter of updating the individual db_revs.
(In reply to David Nind from comment #1) > I'm happy to have a go at this, if it is just a matter of updating the > individual db_revs. Hi David, yes, the mission would be to make the output messages more standardized.
Created attachment 175580 [details] [review] Bug 38448: Fix inconsistencies in database update messages This fixes some database update messages to improve their consistency with the database update guidelines https://wiki.koha-community.org/wiki/Database_updates Test plan: 1. Apply the patch. 2. Review the differences to make sure the messages make sense and are consistent with the database update guidelines: 2.1 Review the diff attached to the bug or 2.2 Run: git show 3. Sign off D: Signed-off-by: David Nind <david@davidnind.com>
Here is a list of the changes and the reason: 1. Consistency with other messages and improve wording: From: "list_borrowers added to $count users with XXX" To: "Added permission 'list_borrowers' to $count users with 'XXX' permissions" 2. Changed the type of message from info (blue) to success (green): From: say_info( $out, "Added column 'service_platformerm_usage_data_providers'" ); To: say_success( $out, "Added column 'service_platformerm_usage_data_providers'" ); 3. Changed the type of message from plain (white) to success (green): From: say $out "Added new system preference 'JobsNotificationMethod'"; To: say_success( $out, "Added new system preference 'JobsNotificationMethod'" ); 4. Consistency with other messages: From: "Added BOOKING_CANCELLATION authorised value category" To: "Added new authorized value category 'BOOKING_CANCELLATION'" 5. Removed 'noisy' message that is not required: say_success( $out, "Updated manage_search_targets permission description" ); 6. Consistency with other messages: From: "Added OAI-PMH:HarvestEmailReport system preference To: "Added new system preference 'OAI-PMH:HarvestEmailReport'"
Created attachment 176165 [details] [review] Bug 38448: Fix inconsistencies in database update messages This fixes some database update messages to improve their consistency with the database update guidelines https://wiki.koha-community.org/wiki/Database_updates Test plan: 1. Apply the patch. 2. Review the differences to make sure the messages make sense and are consistent with the database update guidelines: 2.1 Review the diff attached to the bug or 2.2 Run: git show 3. Sign off D: Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Leo Stoyanov <leo.stoyanov@bywatersolutions.com>
Thanks Leo for the sign off!
Created attachment 176317 [details] [review] Bug 38448: Fix inconsistencies in database update messages This fixes some database update messages to improve their consistency with the database update guidelines https://wiki.koha-community.org/wiki/Database_updates Test plan: 1. Apply the patch. 2. Review the differences to make sure the messages make sense and are consistent with the database update guidelines: 2.1 Review the diff attached to the bug or 2.2 Run: git show 3. Sign off D: Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Leo Stoyanov <leo.stoyanov@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 25.05! Well done everyone, thank you!