Summary: | Add classes to reports homepage | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
Component: | Staff interface | Assignee: | Andrew Fuerste-Henry <andrew> |
Status: | Pushed to main --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, gmcharlt, martin.renvoize, sam.sowanick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This enhancement adds CSS classes to each of the main sections on the reports home page:
- Reports dictionary: rep_dictionary *
- Statistics wizards: rep_wizards
- Report plugins: rep_plugins
- Top lists: rep_top
- Inactive: rep_inactive
- Other: rep_other
* This change also corrects the heading level for reports dictionary to an H2 (from an H5), to correctly reflect the page structure.
|
Version(s) released in: |
25.05.00
|
Circulation function: | |||
Attachments: |
Bug 38521: Add classes to reports homepage
Bug 38521: Add classes to reports homepage Bug 38521: Add classes to reports homepage Bug 38521: (follow-up) Update heading level |
Description
Andrew Fuerste-Henry
2024-11-22 17:54:28 UTC
Created attachment 174942 [details] [review] Bug 38521: Add classes to reports homepage To test: 1 - inspect the page, see lack of distinct classes on separate sets of links 2 - apply patch 3 - reload page, confirm it looks and acts the same 4 - inspect page, confirm classes for each set of links Created attachment 174985 [details] [review] Bug 38521: Add classes to reports homepage To test: 1 - inspect the page, see lack of distinct classes on separate sets of links 2 - apply patch 3 - reload page, confirm it looks and acts the same 4 - inspect page, confirm classes for each set of links Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> I'm sure just some puns would have been fine! (In reply to SamSowanick from comment #3) > I'm sure just some puns would have been fine! Best not, in a classy place like this. Looks like an enh to me. Please correct me if I am mistaken. Created attachment 175587 [details] [review] Bug 38521: Add classes to reports homepage To test: 1 - inspect the page, see lack of distinct classes on separate sets of links 2 - apply patch 3 - reload page, confirm it looks and acts the same 4 - inspect page, confirm classes for each set of links Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 175588 [details] [review] Bug 38521: (follow-up) Update heading level It became apparent to me that we weren't following best practice for working up headings levels on this page whilst reviewing this bug. This patch updates the 'Reports dictionary' section heading to match the other similar headings on the page from h5 to h2. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> (In reply to Marcel de Rooy from comment #5) > Looks like an enh to me. Please correct me if I am mistaken. As I was just thinking the same thing... I guess changing from h5 to h2 is a bugfix bit, but switching to enh for now. RMaint might still consider, as it's a small change. Pushed for 25.05! Well done everyone, thank you! |