Bug 38521

Summary: Add classes to reports homepage
Product: Koha Reporter: Andrew Fuerste-Henry <andrew>
Component: Staff interfaceAssignee: Andrew Fuerste-Henry <andrew>
Status: Pushed to main --- QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: enhancement    
Priority: P5 - low CC: david, gmcharlt, martin.renvoize, sam.sowanick
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
This enhancement adds CSS classes to each of the main sections on the reports home page: - Reports dictionary: rep_dictionary * - Statistics wizards: rep_wizards - Report plugins: rep_plugins - Top lists: rep_top - Inactive: rep_inactive - Other: rep_other * This change also corrects the heading level for reports dictionary to an H2 (from an H5), to correctly reflect the page structure.
Version(s) released in:
25.05.00
Circulation function:
Attachments: Bug 38521: Add classes to reports homepage
Bug 38521: Add classes to reports homepage
Bug 38521: Add classes to reports homepage
Bug 38521: (follow-up) Update heading level

Description Andrew Fuerste-Henry 2024-11-22 17:54:28 UTC
/cgi-bin/koha/reports/reports-home.pl is quite classless, which makes it hard to point at with jQuery and CSS. I'd like to add some classes. It's incredibly hard not to fill this bug filing with dumb "class" puns.
Comment 1 Andrew Fuerste-Henry 2024-11-22 18:13:40 UTC
Created attachment 174942 [details] [review]
Bug 38521: Add classes to reports homepage

To test:
1 - inspect the page, see lack of distinct classes on separate sets of links
2 - apply patch
3 - reload page, confirm it looks and acts the same
4 - inspect page, confirm classes for each set of links
Comment 2 Biblibre Sandboxes 2024-11-25 23:56:05 UTC
Created attachment 174985 [details] [review]
Bug 38521: Add classes to reports homepage

To test:
1 - inspect the page, see lack of distinct classes on separate sets of links
2 - apply patch
3 - reload page, confirm it looks and acts the same
4 - inspect page, confirm classes for each set of links

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Comment 3 SamSowanick 2024-11-25 23:59:22 UTC
I'm sure just some puns would have been fine!
Comment 4 Andrew Fuerste-Henry 2024-11-26 14:02:13 UTC
(In reply to SamSowanick from comment #3)
> I'm sure just some puns would have been fine!

Best not, in a classy place like this.
Comment 5 Marcel de Rooy 2024-12-13 08:51:19 UTC
Looks like an enh to me. Please correct me if I am mistaken.
Comment 6 Martin Renvoize (ashimema) 2024-12-17 07:03:42 UTC
Created attachment 175587 [details] [review]
Bug 38521: Add classes to reports homepage

To test:
1 - inspect the page, see lack of distinct classes on separate sets of links
2 - apply patch
3 - reload page, confirm it looks and acts the same
4 - inspect page, confirm classes for each set of links

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 7 Martin Renvoize (ashimema) 2024-12-17 07:03:44 UTC
Created attachment 175588 [details] [review]
Bug 38521: (follow-up) Update heading level

It became apparent to me that we weren't following best practice for
working up headings levels on this page whilst reviewing this bug.

This patch updates the 'Reports dictionary' section heading to match the
other similar headings on the page from h5 to h2.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 8 Katrin Fischer 2024-12-23 09:23:44 UTC
(In reply to Marcel de Rooy from comment #5)
> Looks like an enh to me. Please correct me if I am mistaken.

As I was just thinking the same thing... I guess changing from h5 to h2 is a bugfix bit, but switching to enh for now. RMaint might still consider, as it's a small change.
Comment 9 Katrin Fischer 2024-12-23 09:37:43 UTC
Pushed for 25.05!

Well done everyone, thank you!