Bug 40647 - "dictionary" misspelled in rep_dictonary class
Summary: "dictionary" misspelled in rep_dictonary class
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Andrew Fuerste-Henry
QA Contact: Testopia
URL:
Keywords:
Depends on: 38521
Blocks:
  Show dependency treegraph
 
Reported: 2025-08-13 18:57 UTC by Andrew Fuerste-Henry
Modified: 2025-08-15 06:39 UTC (History)
4 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes a spelling error in the class name on the reports home page in the staff interface: "rep_dictonary" to "rep_dictionary".
Version(s) released in:
Circulation function:


Attachments
Bug 40647: Spell dictionary correctly (1.23 KB, patch)
2025-08-13 19:01 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 40647: Spell dictionary correctly (1.38 KB, patch)
2025-08-14 16:36 UTC, David Nind
Details | Diff | Splinter Review
Bug 40647: Spell dictionary correctly (1.43 KB, patch)
2025-08-15 06:37 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2025-08-13 18:57:43 UTC
On bug 38521 I misspelled "dictionary" in the class for the Reports Dictionary. It's missing the second "i"

To observe:
- go to /cgi-bin/koha/reports/reports-home.pl
- inspect the label "Reports dictionary"
- see that it has the class "rep_dictonary"
Comment 1 Andrew Fuerste-Henry 2025-08-13 19:01:40 UTC
Created attachment 185378 [details] [review]
Bug 40647: Spell dictionary correctly

To test:
1 - go to reports home
2 - inspect Reports dictionary
3 - see that it has class rep_dictonary
4 - apply patch, reload page
5 - see that class is now rep_dictionary
Comment 2 Anneli Österman 2025-08-14 10:01:50 UTC
I tested this in a Bywater's sandbox but signing off did not work there so I'll just confirm here that the class was correct after I applied the batch.
Comment 3 Anneli Österman 2025-08-14 10:17:14 UTC
I asked in Mattermost (https://chat.koha-community.org/koha-community/pl/wweqmk9ap7ys3miu67kwjdhziy) about the error I got  and Katrin recommended to set this bug as Patch does not apply.

The error while trying to sign of was:

Saved working directory and index state WIP on main: 8d31c2e067 Bug 40608: (QA follow-up) Delete notice in test, adjust about.tt
/bin/sh: 1: Ãsterman: not found
fatal: It looks like 'git am' is in progress. Cannot rebase.

On branch main
Your branch is up to date with 'origin/main'.

You are in the middle of an am session.
  (fix conflicts and then run "git am --continue")
  (use "git am --skip" to skip this patch)
  (use "git am --abort" to restore the original branch)

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	[31mmodified:   koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt[m

no changes added to commit (use "git add" and/or "git commit -a")
Dropped refs/stash@{0} (815c81d5a813e5b61b1246fa5dcffbd86f9fad4c)
Comment 4 David Nind 2025-08-14 16:36:15 UTC
Created attachment 185405 [details] [review]
Bug 40647: Spell dictionary correctly

To test:
1 - go to reports home
2 - inspect Reports dictionary
3 - see that it has class rep_dictonary
4 - apply patch, reload page
5 - see that class is now rep_dictionary

Signed-off-by:  Anneli Österman <anneli.osterman@koha-suomi.fi>
Comment 5 David Nind 2025-08-14 16:41:04 UTC
Hi Anneli.

There must be something wrong with the sandboxes today - I tried and had issues.

However, in a local development environment (KTD) things work fine.

I've added a sign-off line with your details to the patch.

If you can change the status to signed off, you will get the credit on the dashboard.

David Nind
Comment 6 David Nind 2025-08-15 06:37:48 UTC
Created attachment 185437 [details] [review]
Bug 40647: Spell dictionary correctly

To test:
1 - go to reports home
2 - inspect Reports dictionary
3 - see that it has class rep_dictonary
4 - apply patch, reload page
5 - see that class is now rep_dictionary

Signed-off-by:  Anneli Österman <anneli.osterman@koha-suomi.fi>
Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2025-08-15 06:39:09 UTC
Looks good to me (and something I can QA).

QA script is happy as well.