On bug 38521 I misspelled "dictionary" in the class for the Reports Dictionary. It's missing the second "i" To observe: - go to /cgi-bin/koha/reports/reports-home.pl - inspect the label "Reports dictionary" - see that it has the class "rep_dictonary"
Created attachment 185378 [details] [review] Bug 40647: Spell dictionary correctly To test: 1 - go to reports home 2 - inspect Reports dictionary 3 - see that it has class rep_dictonary 4 - apply patch, reload page 5 - see that class is now rep_dictionary
I tested this in a Bywater's sandbox but signing off did not work there so I'll just confirm here that the class was correct after I applied the batch.
I asked in Mattermost (https://chat.koha-community.org/koha-community/pl/wweqmk9ap7ys3miu67kwjdhziy) about the error I got and Katrin recommended to set this bug as Patch does not apply. The error while trying to sign of was: Saved working directory and index state WIP on main: 8d31c2e067 Bug 40608: (QA follow-up) Delete notice in test, adjust about.tt /bin/sh: 1: Ãsterman: not found fatal: It looks like 'git am' is in progress. Cannot rebase. On branch main Your branch is up to date with 'origin/main'. You are in the middle of an am session. (fix conflicts and then run "git am --continue") (use "git am --skip" to skip this patch) (use "git am --abort" to restore the original branch) Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git restore <file>..." to discard changes in working directory) [31mmodified: koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt[m no changes added to commit (use "git add" and/or "git commit -a") Dropped refs/stash@{0} (815c81d5a813e5b61b1246fa5dcffbd86f9fad4c)
Created attachment 185405 [details] [review] Bug 40647: Spell dictionary correctly To test: 1 - go to reports home 2 - inspect Reports dictionary 3 - see that it has class rep_dictonary 4 - apply patch, reload page 5 - see that class is now rep_dictionary Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi>
Hi Anneli. There must be something wrong with the sandboxes today - I tried and had issues. However, in a local development environment (KTD) things work fine. I've added a sign-off line with your details to the patch. If you can change the status to signed off, you will get the credit on the dashboard. David Nind
Created attachment 185437 [details] [review] Bug 40647: Spell dictionary correctly To test: 1 - go to reports home 2 - inspect Reports dictionary 3 - see that it has class rep_dictonary 4 - apply patch, reload page 5 - see that class is now rep_dictionary Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: David Nind <david@davidnind.com>
Looks good to me (and something I can QA). QA script is happy as well.