| Summary: | Non-existent hc-sticky asset included in opac-tags | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | Pushed to stable --- | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | david, lucas, wainuiwitikapark |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This removes an obsolete reference to the hc-sicky JavaScript library for the OPAC tags page - hc-sticky is no longer included in Koha.
|
Version(s) released in: |
25.05.00,24.11.01
|
| Circulation function: | |||
| Bug Depends on: | 36557, 36694 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 38620: Remove obsolete reference to hc-sicky on OPAC tags page
Bug 38620: Remove obsolete reference to hc-sicky on OPAC tags page Bug 38620: Remove obsolete reference to hc-sicky on OPAC tags page |
||
Created attachment 175192 [details] [review] Bug 38620: Remove obsolete reference to hc-sicky on OPAC tags page This patch removes code intended to include the hc-sticky js library. hc-sticky is not longer included in Koha. To test, apply the patch and make sure the TagsEnabled system preference is turned on. Log in to the OPAC and go to the tags page. Everything should work correctly. There should be no errors in the developer console. Is there something here that should be sticky? Toolbar, maybe? (In reply to Lucas Gass (lukeg) from comment #2) > Is there something here that should be sticky? Toolbar, maybe? From bug 36694: OPAC: 20. Add many items to an OPAC cart. Make sure the toolbar sticks. 21. Try the OPAC results, the toolbar should stick 22. Add many items to a list, on the OPAC list display the toolbar should stick. OK, nothing on the opac-tags looks like it needs to stick. Created attachment 175196 [details] [review] Bug 38620: Remove obsolete reference to hc-sicky on OPAC tags page This patch removes code intended to include the hc-sticky js library. hc-sticky is not longer included in Koha. To test, apply the patch and make sure the TagsEnabled system preference is turned on. Log in to the OPAC and go to the tags page. Everything should work correctly. There should be no errors in the developer console. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 175197 [details] [review] Bug 38620: Remove obsolete reference to hc-sicky on OPAC tags page This patch removes code intended to include the hc-sticky js library. hc-sticky is not longer included in Koha. To test, apply the patch and make sure the TagsEnabled system preference is turned on. Log in to the OPAC and go to the tags page. Everything should work correctly. There should be no errors in the developer console. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> It looks like this has been signed off and passed QA, but the status is still shown as "Needs Signoff". (In reply to David Nind from comment #7) > It looks like this has been signed off and passed QA, but the status is > still shown as "Needs Signoff". Thanks David, I set it to "Signed-off". Jonathan can set to PQA so he gets credit. :) (In reply to Lucas Gass (lukeg) from comment #8) > (In reply to David Nind from comment #7) > > It looks like this has been signed off and passed QA, but the status is > > still shown as "Needs Signoff". > > Thanks David, I set it to "Signed-off". Jonathan can set to PQA so he gets > credit. :) Thanks Lucas! Pushed for 25.05! Well done everyone, thank you! Nice work everyone! Pushed to 24.11.x for 24.11.01 Not backporting to 24.05.x |
[% Asset.js("lib/hc-sticky/hc-sticky.js") | $raw %] But it got removed by bug 36694