Bug 38620 - Non-existent hc-sticky asset included in opac-tags
Summary: Non-existent hc-sticky asset included in opac-tags
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 36557 36694
Blocks:
  Show dependency tree / graph
 
Reported: 2024-12-04 12:13 UTC by Jonathan Druart
Modified: 2024-12-18 00:25 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This removes an obsolete reference to the hc-sicky JavaScript library for the OPAC tags page - hc-sticky is no longer included in Koha.
Version(s) released in:
25.05.00,24.11.01
Circulation function:

Attachments
Bug 38620: Remove obsolete reference to hc-sicky on OPAC tags page (1.23 KB, patch)
2024-12-04 14:07 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 38620: Remove obsolete reference to hc-sicky on OPAC tags page (1.28 KB, patch)
2024-12-04 14:55 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 38620: Remove obsolete reference to hc-sicky on OPAC tags page (1.36 KB, patch)
2024-12-04 15:16 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-12-04 12:13:57 UTC 
[% Asset.js("lib/hc-sticky/hc-sticky.js") | $raw %]

But it got removed by bug 36694
Comment 1 Owen Leonard 2024-12-04 14:07:24 UTC 
Created attachment 175192 [details] [review]
Bug 38620: Remove obsolete reference to hc-sicky on OPAC tags page

This patch removes code intended to include the hc-sticky js library.
hc-sticky is not longer included in Koha.

To test, apply the patch and make sure the TagsEnabled system preference
is turned on.

Log in to the OPAC and go to the tags page. Everything should work
correctly. There should be no errors in the developer console.
Comment 2 Lucas Gass (lukeg) 2024-12-04 14:44:11 UTC 
Is there something here that should be sticky? Toolbar, maybe?
Comment 3 Katrin Fischer 2024-12-04 14:47:06 UTC 
(In reply to Lucas Gass (lukeg) from comment #2)
> Is there something here that should be sticky? Toolbar, maybe?

From bug 36694:

OPAC:
20. Add many items to an OPAC cart. Make sure the toolbar sticks.
21. Try the OPAC results, the toolbar should stick
22. Add many items to a list, on the OPAC list display the toolbar
    should stick.
Comment 4 Lucas Gass (lukeg) 2024-12-04 14:54:22 UTC 
OK, nothing on the opac-tags looks like it needs to stick.
Comment 5 Lucas Gass (lukeg) 2024-12-04 14:55:24 UTC 
Created attachment 175196 [details] [review]
Bug 38620: Remove obsolete reference to hc-sicky on OPAC tags page

This patch removes code intended to include the hc-sticky js library.
hc-sticky is not longer included in Koha.

To test, apply the patch and make sure the TagsEnabled system preference
is turned on.

Log in to the OPAC and go to the tags page. Everything should work
correctly. There should be no errors in the developer console.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 6 Jonathan Druart 2024-12-04 15:16:22 UTC 
Created attachment 175197 [details] [review]
Bug 38620: Remove obsolete reference to hc-sicky on OPAC tags page

This patch removes code intended to include the hc-sticky js library.
hc-sticky is not longer included in Koha.

To test, apply the patch and make sure the TagsEnabled system preference
is turned on.

Log in to the OPAC and go to the tags page. Everything should work
correctly. There should be no errors in the developer console.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 David Nind 2024-12-04 22:23:21 UTC 
It looks like this has been signed off and passed QA, but the status is still shown as "Needs Signoff".
Comment 8 Lucas Gass (lukeg) 2024-12-04 22:25:08 UTC 
(In reply to David Nind from comment #7)
> It looks like this has been signed off and passed QA, but the status is
> still shown as "Needs Signoff".

Thanks David, I set it to "Signed-off". Jonathan can set to PQA so he gets credit. :)
Comment 9 David Nind 2024-12-04 22:59:57 UTC 
(In reply to Lucas Gass (lukeg) from comment #8)
> (In reply to David Nind from comment #7)
> > It looks like this has been signed off and passed QA, but the status is
> > still shown as "Needs Signoff".
> 
> Thanks David, I set it to "Signed-off". Jonathan can set to PQA so he gets
> credit. :)

Thanks Lucas!
Comment 10 Katrin Fischer 2024-12-05 14:44:49 UTC 
Pushed for 25.05!

Well done everyone, thank you!
Comment 11 Paul Derscheid 2024-12-12 13:31:40 UTC 
Nice work everyone!

Pushed to 24.11.x for 24.11.01
Comment 12 Wainui Witika-Park 2024-12-18 00:25:41 UTC 
Not backporting to 24.05.x