Summary: | Holdings table - filters shown after column visibility is updated | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Staff interface | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | Pushed to stable --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, gmcharlt, victor |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38632 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes the holdings table. If you clicked "Columns" and you added or removed a column, it was automatically showing the column filters - but it didn't toggle "Hide filters" and you had to click twice to hide them.
|
|
Version(s) released in: |
25.05.00,24.11.04
|
Circulation function: | |
Bug Depends on: | 38485 | ||
Bug Blocks: | |||
Attachments: |
Bug 38724: Do not show the filters when updating col vis (if not needed)
Bug 38724: Do not show the filters when updating col vis (if not needed) Bug 38724: Do not show the filters when updating col vis (if not needed) Bug 38724: Do not show the filters when updating col vis (if not needed) |
Description
Jonathan Druart
2024-12-17 09:11:51 UTC
Created attachment 175597 [details] [review] Bug 38724: Do not show the filters when updating col vis (if not needed) (In reply to Brendan Lawlor from bug 38632 comment #7) > During testing I noticed small related bug in current main. On the > bibliographic record details page if you click to configure columns and you > add or remove a column it automatically shows the column filters too, but it > does not toggle the filter link to 'Hide filters` so you have to click twice > to hide them. Created attachment 175625 [details] [review] Bug 38724: Do not show the filters when updating col vis (if not needed) (In reply to Brendan Lawlor from bug 38632 comment #7) > During testing I noticed small related bug in current main. On the > bibliographic record details page if you click to configure columns and you > add or remove a column it automatically shows the column filters too, but it > does not toggle the filter link to 'Hide filters` so you have to click twice > to hide them. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 176052 [details] [review] Bug 38724: Do not show the filters when updating col vis (if not needed) (In reply to Brendan Lawlor from bug 38632 comment #7) > During testing I noticed small related bug in current main. On the > bibliographic record details page if you click to configure columns and you > add or remove a column it automatically shows the column filters too, but it > does not toggle the filter link to 'Hide filters` so you have to click twice > to hide them. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 176053 [details] [review] Bug 38724: Do not show the filters when updating col vis (if not needed) (In reply to Brendan Lawlor from bug 38632 comment #7) > During testing I noticed small related bug in current main. On the > bibliographic record details page if you click to configure columns and you > add or remove a column it automatically shows the column filters too, but it > does not toggle the filter link to 'Hide filters` so you have to click twice > to hide them. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Works, makes sense, QA script happy, code looks good, passing QA :) Pushed for 25.05! Well done everyone, thank you! Nice work everyone! Pushed to 24.11.x for 24.11.04 |