Coming from bug 38632 comment 7 ``` During testing I noticed small related bug in current main. On the bibliographic record details page if you click to configure columns and you add or remove a column it automatically shows the column filters too, but it does not toggle the filter link to 'Hide filters` so you have to click twice to hide them. ```
Created attachment 175597 [details] [review] Bug 38724: Do not show the filters when updating col vis (if not needed) (In reply to Brendan Lawlor from bug 38632 comment #7) > During testing I noticed small related bug in current main. On the > bibliographic record details page if you click to configure columns and you > add or remove a column it automatically shows the column filters too, but it > does not toggle the filter link to 'Hide filters` so you have to click twice > to hide them.
Created attachment 175625 [details] [review] Bug 38724: Do not show the filters when updating col vis (if not needed) (In reply to Brendan Lawlor from bug 38632 comment #7) > During testing I noticed small related bug in current main. On the > bibliographic record details page if you click to configure columns and you > add or remove a column it automatically shows the column filters too, but it > does not toggle the filter link to 'Hide filters` so you have to click twice > to hide them. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Created attachment 176052 [details] [review] Bug 38724: Do not show the filters when updating col vis (if not needed) (In reply to Brendan Lawlor from bug 38632 comment #7) > During testing I noticed small related bug in current main. On the > bibliographic record details page if you click to configure columns and you > add or remove a column it automatically shows the column filters too, but it > does not toggle the filter link to 'Hide filters` so you have to click twice > to hide them. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Created attachment 176053 [details] [review] Bug 38724: Do not show the filters when updating col vis (if not needed) (In reply to Brendan Lawlor from bug 38632 comment #7) > During testing I noticed small related bug in current main. On the > bibliographic record details page if you click to configure columns and you > add or remove a column it automatically shows the column filters too, but it > does not toggle the filter link to 'Hide filters` so you have to click twice > to hide them. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, makes sense, QA script happy, code looks good, passing QA :)
Pushed for 25.05! Well done everyone, thank you!