If we click on "Show filters" all the columns are shown.
Created attachment 175296 [details] [review] Bug 38632: Do not show all columns when displaying the filters Yet another visibility bug fix for this specific table. When the filters are displayed the table is destroyed and recreated. We should not save the visibility changes made by DT and consider them changes made by the user. A temporary variable is used to store the user settings duringt this action, then we restore them once it's done. Test plan: Go to the detail page of bibliographic record with items Click on "show filters" => Only columns displayed should still be displayed Retry but show/hide some columns before you display the filters => Only columns displayed should still be displayed
Created attachment 175297 [details] [review] Bug 38632: Add tests You need bug 38461 to run successfully this test.
Not adding the dependency on bug 38632 because the first patch should be backported (with or without the tests).
Not adding the dependency on bug 38461 because the first patch should be backported (with or without the tests).
Created attachment 175380 [details] [review] Bug 38632: Do not show all columns when displaying the filters Yet another visibility bug fix for this specific table. When the filters are displayed the table is destroyed and recreated. We should not save the visibility changes made by DT and consider them changes made by the user. A temporary variable is used to store the user settings duringt this action, then we restore them once it's done. Test plan: Go to the detail page of bibliographic record with items Click on "show filters" => Only columns displayed should still be displayed Retry but show/hide some columns before you display the filters => Only columns displayed should still be displayed Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Created attachment 175381 [details] [review] Bug 38632: Add tests You need bug 38461 to run successfully this test. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
This works as described. During testing I noticed small related bug in current main. On the bibliographic record details page if you click to configure columns and you add or remove a column it automatically shows the column filters too, but it does not toggle the filter link to 'Hide filters` so you have to click twice to hide them. In 24.05 configuring the columns does not automatically show the column filters so I think it's a regression in 24.11 I tried to run the cypress tests but couldn't get it to work: kohadev-koha@kohadevbox:koha(main)$ cypress run --spec t/cypress/integration/KohaTable_spec.ts [18586:1211/194337.239929:ERROR:gpu_memory_buffer_support_x11.cc(44)] dri3 extension not supported. DevTools listening on ws://127.0.0.1:46069/devtools/browser/82072b5e-0295-4314-b0dd-1937534ca2f2 Missing baseUrl in compilerOptions. tsconfig-paths will be skipped Your configFile threw an error from: /kohadevbox/koha/cypress.config.ts
sha1 issues on attempting to apply I'm afraid
(In reply to Martin Renvoize (ashimema) from comment #8) > sha1 issues on attempting to apply I'm afraid "You need bug 38461 to run successfully this test." I have not added the dependency to not confuse RMaint as the first patch needs to be backported.
(In reply to Brendan Lawlor from comment #7) > During testing I noticed small related bug in current main. On the > bibliographic record details page if you click to configure columns and you > add or remove a column it automatically shows the column filters too, but it > does not toggle the filter link to 'Hide filters` so you have to click twice > to hide them. See bug 38724.
Created attachment 175984 [details] [review] Bug 38632: Do not show all columns when displaying the filters Yet another visibility bug fix for this specific table. When the filters are displayed the table is destroyed and recreated. We should not save the visibility changes made by DT and consider them changes made by the user. A temporary variable is used to store the user settings duringt this action, then we restore them once it's done. Test plan: Go to the detail page of bibliographic record with items Click on "show filters" => Only columns displayed should still be displayed Retry but show/hide some columns before you display the filters => Only columns displayed should still be displayed Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Created attachment 175985 [details] [review] Bug 38632: Add tests You need bug 38461 to run successfully this test. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
I have trouble applying these: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 38632: Do not show all columns when displaying the filters Applying: Bug 38632: Add tests error: sha1 information is lacking or useless (t/cypress/integration/KohaTable_spec.ts). error: could not build fake ancestor Patch failed at 0001 Bug 38632: Add tests hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-38632-Add-tests-nmpntz93.patch I have some patches on my branch. I'll push these now. Could you try and see if you can rebase/reattach the patches maybe Matt?
You need bug 38461 - its signed off so I'll QA that now and then it should apply
(In reply to Matt Blenkinsop from comment #14) > You need bug 38461 - its signed off so I'll QA that now and then it should > apply On a closer look there are other bugs in the tree that also need QA
(In reply to Matt Blenkinsop from comment #15) > (In reply to Matt Blenkinsop from comment #14) > > You need bug 38461 - its signed off so I'll QA that now and then it should > > apply > > On a closer look there are other bugs in the tree that also need QA How do you tell? There is no depdendeny on this bug but for the RESOLVED bug 38485?
See comment 4 - the tests patch needs the dependency but the first one doesn't
(In reply to Matt Blenkinsop from comment #17) > See comment 4 - the tests patch needs the dependency but the first one > doesn't OK, waiting for the dependency bug 38461 to pass QA. We should have the tests in main.
I have bug 38632 applied now, but still doesn't apply: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 38632: Do not show all columns when displaying the filters Applying: Bug 38632: Add tests error: sha1 information is lacking or useless (t/cypress/integration/KohaTable_spec.ts). error: could not build fake ancestor Patch failed at 0001 Bug 38632: Add tests hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-38632-Add-tests-e47wbro9.patch
Ah, wrong bug... still waiting for the depdency one.
RMAINTS please note: (In reply to Jonathan Druart from comment #4) > Not adding the dependency on bug 38461 because the first patch should be > backported (with or without the tests).
Pushed for 25.05! Well done everyone, thank you!