| Summary: | Remove @vue/cli-service and babel | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Victor Grousset/tuxayo <victor> |
| Component: | Architecture, internals, and plumbing | Assignee: | Victor Grousset/tuxayo <victor> |
| Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | david |
| Version: | Main | Keywords: | release-notes-needed |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 38167, 38426 | ||
| Attachments: |
Bug 38770 - Remove @vue/cli-service and babel
Bug 38770: Remove @vue/cli-service and babel Bug 38770: [DO NOT PUSH] yarn.lock changes Bug 38770: Remove @vue/cli-service and babel Bug 38770: [DO NOT PUSH] yarn.lock changes |
||
|
Description
Victor Grousset/tuxayo
2024-12-22 08:25:38 UTC
Created attachment 175885 [details] [review] Bug 38770 - Remove @vue/cli-service and babel And the webpack related dead config. Created attachment 175886 [details] [review] Bug 38770: Remove @vue/cli-service and babel And the webpack related dead config. Test plan: 1. Do not apply 2. Switch to node 22 sudo sed 's/18.x/22.x/g' -i /etc/apt/sources.list.d/nodesource.list sudo apt update ; sudo apt install nodejs 3. Try to install node deps sudo yarn install --modules-folder /kohadevbox/node_modules 4. It fails error @achrinza/node-ipc@9.2.5: The engine "node" is incompatible with this module. Expected version "8 || 9 || 10 || 11 || 12 || 13 || 14 || 15 || 16 || 17 || 18". Got "22.12.0" 5. Apply patches 6. Try to install node deps sudo yarn install --modules-folder /kohadevbox/node_modules 7. It works! :) Created attachment 175887 [details] [review] Bug 38770: [DO NOT PUSH] yarn.lock changes Created attachment 175947 [details] [review] Bug 38770: Remove @vue/cli-service and babel And the webpack related dead config. Test plan: 1. Do not apply 2. Switch to node 22 sudo sed 's/18.x/22.x/g' -i /etc/apt/sources.list.d/nodesource.list sudo apt update ; sudo apt install nodejs 3. Try to install node deps sudo yarn install --modules-folder /kohadevbox/node_modules 4. It fails error @achrinza/node-ipc@9.2.5: The engine "node" is incompatible with this module. Expected version "8 || 9 || 10 || 11 || 12 || 13 || 14 || 15 || 16 || 17 || 18". Got "22.12.0" 5. Apply patches 6. Try to install node deps sudo yarn install --modules-folder /kohadevbox/node_modules 7. It works! :) Signed-off-by: David Nind <david@davidnind.com> Created attachment 175948 [details] [review] Bug 38770: [DO NOT PUSH] yarn.lock changes Signed-off-by: David Nind <david@davidnind.com> Everything worked as per the test plan. I got these warnings after applying the patch - not sure if these need fixing: sudo yarn install --modules-folder /kohadevbox/node_modules yarn install v1.22.22 [1/4] Resolving packages... [2/4] Fetching packages... [3/4] Linking dependencies... warning "@redocly/cli > redoc > @cfaester/enzyme-adapter-react-18@0.8.0" has unmet peer dependency "enzyme@^3.11.0". warning " > eslint-config-prettier@9.1.0" has unmet peer dependency "eslint@>=7.0.0". warning " > eslint-plugin-prettier@5.1.3" has unmet peer dependency "eslint@>=8.0.0". warning " > eslint-plugin-prettier@5.1.3" has unmet peer dependency "prettier@>=3.0.0". warning "swagger-cli > @apidevtools/swagger-cli > @apidevtools/swagger-parser@10.1.0" has unmet peer dependency "openapi-types@>=7". [4/4] Building fresh packages... Done in 41.20s. |