It's needed for bug 38167 and Bug 38426.
Created attachment 175885 [details] [review] Bug 38770 - Remove @vue/cli-service and babel And the webpack related dead config.
Created attachment 175886 [details] [review] Bug 38770: Remove @vue/cli-service and babel And the webpack related dead config. Test plan: 1. Do not apply 2. Switch to node 22 sudo sed 's/18.x/22.x/g' -i /etc/apt/sources.list.d/nodesource.list sudo apt update ; sudo apt install nodejs 3. Try to install node deps sudo yarn install --modules-folder /kohadevbox/node_modules 4. It fails error @achrinza/node-ipc@9.2.5: The engine "node" is incompatible with this module. Expected version "8 || 9 || 10 || 11 || 12 || 13 || 14 || 15 || 16 || 17 || 18". Got "22.12.0" 5. Apply patches 6. Try to install node deps sudo yarn install --modules-folder /kohadevbox/node_modules 7. It works! :)
Created attachment 175887 [details] [review] Bug 38770: [DO NOT PUSH] yarn.lock changes
Created attachment 175947 [details] [review] Bug 38770: Remove @vue/cli-service and babel And the webpack related dead config. Test plan: 1. Do not apply 2. Switch to node 22 sudo sed 's/18.x/22.x/g' -i /etc/apt/sources.list.d/nodesource.list sudo apt update ; sudo apt install nodejs 3. Try to install node deps sudo yarn install --modules-folder /kohadevbox/node_modules 4. It fails error @achrinza/node-ipc@9.2.5: The engine "node" is incompatible with this module. Expected version "8 || 9 || 10 || 11 || 12 || 13 || 14 || 15 || 16 || 17 || 18". Got "22.12.0" 5. Apply patches 6. Try to install node deps sudo yarn install --modules-folder /kohadevbox/node_modules 7. It works! :) Signed-off-by: David Nind <david@davidnind.com>
Created attachment 175948 [details] [review] Bug 38770: [DO NOT PUSH] yarn.lock changes Signed-off-by: David Nind <david@davidnind.com>
Everything worked as per the test plan. I got these warnings after applying the patch - not sure if these need fixing: sudo yarn install --modules-folder /kohadevbox/node_modules yarn install v1.22.22 [1/4] Resolving packages... [2/4] Fetching packages... [3/4] Linking dependencies... warning "@redocly/cli > redoc > @cfaester/enzyme-adapter-react-18@0.8.0" has unmet peer dependency "enzyme@^3.11.0". warning " > eslint-config-prettier@9.1.0" has unmet peer dependency "eslint@>=7.0.0". warning " > eslint-plugin-prettier@5.1.3" has unmet peer dependency "eslint@>=8.0.0". warning " > eslint-plugin-prettier@5.1.3" has unmet peer dependency "prettier@>=3.0.0". warning "swagger-cli > @apidevtools/swagger-cli > @apidevtools/swagger-parser@10.1.0" has unmet peer dependency "openapi-types@>=7". [4/4] Building fresh packages... Done in 41.20s.
> I got these warnings after applying the patch - not sure if these need fixing: They will be fixed by bug 38149. Thanks for the conscientious testing :)
Created attachment 176114 [details] [review] Bug 38770: Remove @vue/cli-service and babel And the webpack related dead config. Test plan: 1. Do not apply 2. Switch to node 22 sudo sed 's/18.x/22.x/g' -i /etc/apt/sources.list.d/nodesource.list sudo apt update ; sudo apt install nodejs 3. Try to install node deps sudo yarn install --modules-folder /kohadevbox/node_modules 4. It fails error @achrinza/node-ipc@9.2.5: The engine "node" is incompatible with this module. Expected version "8 || 9 || 10 || 11 || 12 || 13 || 14 || 15 || 16 || 17 || 18". Got "22.12.0" 5. Apply patches 6. Try to install node deps sudo yarn install --modules-folder /kohadevbox/node_modules 7. It works! :) Signed-off-by: David Nind <david@davidnind.com>
Rebased.
The patch no longer applies 8-(... git bz apply 38770 Bug 38770 - Remove @vue/cli-service and babel 175948 - Bug 38770: [DO NOT PUSH] yarn.lock changes 176114 - Bug 38770: Remove @vue/cli-service and babel Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 38770: [DO NOT PUSH] yarn.lock changes Applying: Bug 38770: Remove @vue/cli-service and babel Using index info to reconstruct a base tree... M package.json M t/cypress/plugins/index.js Falling back to patching base and 3-way merge... Auto-merging t/cypress/plugins/index.js CONFLICT (content): Merge conflict in t/cypress/plugins/index.js Auto-merging package.json error: Failed to merge in the changes. Patch failed at 0001 Bug 38770: Remove @vue/cli-service and babel
The conflict I solved yesterday was not legit. Likely the result of testing another patch related to prettier. (and committing the result???). So I rollbacked the attachment changes. And it applies :)
Created attachment 176143 [details] [review] Bug 38770: [DO NOT PUSH] yarn.lock changes Signed-off-by: David Nind <david@davidnind.com>
It is simply not possible to have this being applicable alone and in bug 38524 deps at the same time. Because a dependency of 38524 (Bug 38149 but I'm not sure) conflicts with this (38770) on yarn.lock. So solving the conflicts for the case of 38770 alone and the case for having 38770 in the dependency tree of 38524 is not possible at the same time. Whatever, let's try to not have any yarn.lock patch. yarn install is ran in the test plans. And I don't think that even help using the sandboxes. It's just to have a clean working directory I guess?
Created attachment 176144 [details] [review] Bug 38770: Remove @vue/cli-service and babel And the webpack related dead config. Test plan: 1. Do not apply 2. Switch to node 22 sudo sed 's/18.x/22.x/g' -i /etc/apt/sources.list.d/nodesource.list sudo apt update ; sudo apt install nodejs 3. Try to install node deps sudo yarn install --modules-folder /kohadevbox/node_modules 4. It fails error @achrinza/node-ipc@9.2.5: The engine "node" is incompatible with this module. Expected version "8 || 9 || 10 || 11 || 12 || 13 || 14 || 15 || 16 || 17 || 18". Got "22.12.0" 5. Apply patches 6. Try to install node deps sudo yarn install --modules-folder /kohadevbox/node_modules 7. It works! :) Signed-off-by: David Nind <david@davidnind.com>
Created attachment 176192 [details] [review] Bug 38770: Remove @vue/cli-service and babel And the webpack related dead config. Test plan: 1. Do not apply 2. Switch to node 22 sudo sed 's/18.x/22.x/g' -i /etc/apt/sources.list.d/nodesource.list sudo apt update ; sudo apt install nodejs 3. Try to install node deps sudo yarn install --modules-folder /kohadevbox/node_modules 4. It fails error @achrinza/node-ipc@9.2.5: The engine "node" is incompatible with this module. Expected version "8 || 9 || 10 || 11 || 12 || 13 || 14 || 15 || 16 || 17 || 18". Got "22.12.0" 5. Apply patches 6. Try to install node deps sudo yarn install --modules-folder /kohadevbox/node_modules 7. It works! :) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
I had quite a bit of trouble with some tests, even after updating the yarn.lock file. I am not sure if this one is to blame or 38149 and dependencies. Help appreciated in untangling this next week.
Created attachment 176668 [details] [review] Bug 38770: Remove @vue/cli-service and babel And the webpack related dead config. Test plan: 1. Do not apply 2. Switch to node 22 sudo sed 's/18.x/22.x/g' -i /etc/apt/sources.list.d/nodesource.list sudo apt update ; sudo apt install nodejs 3. Try to install node deps sudo yarn install --modules-folder /kohadevbox/node_modules 4. It fails error @achrinza/node-ipc@9.2.5: The engine "node" is incompatible with this module. Expected version "8 || 9 || 10 || 11 || 12 || 13 || 14 || 15 || 16 || 17 || 18". Got "22.12.0" 5. Apply patches 6. Try to install node deps sudo yarn install --modules-folder /kohadevbox/node_modules 7. It works! :) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 38770: Remove @vue/cli-service and babel error: sha1 information is lacking or useless (package.json). error: could not build fake ancestor Patch failed at 0001 Bug 38770: Remove @vue/cli-service and babel hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-38770-Remove-vuecli-service-and-babel-5oxgc_mh.patch
Pushed for 25.05! Well done everyone, thank you!