Summary: | Row highlighting in the circulation history table for a patron doesn't look great | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Circulation | Assignee: | Leo Stoyanov <leo.stoyanov> |
Status: | Pushed to stable --- | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | normal | ||
Priority: | P5 - low | CC: | clackman, david, gmcharlt, jonathan.druart, katrin.fischer, kebliss, kyle.m.hall, leo.stoyanov, oleonard |
Version: | Main | Keywords: | accessibility |
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the circulation history table for a patron, and makes it easier to identify checked out items:
- the alternating row background colors are now white and grey, rather than:
. Returned items: white/grey
. Checked out items: yellow/grey
- checked out items are now shown as "Checked out" using an orange/gold badge in the "Return date" column
|
Version(s) released in: |
25.05.00,24.11.04
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 38954 | ||
Attachments: |
Proposed change to Bootstrap badges
Bug 38783: Added "Checked out" badge for checked out items in the circulation history table. Bug 38783: Added "Checked out" badge for checked out items in the circulation history table. Bug 38783: Added "Checked out" badge for checked out items in the circulation history table. Bug 38783: (follow-up) Remove obsolete .badge-pill class Bug 38783: Added "Checked out" badge for checked out items in the circulation history table. Bug 38783: (follow-up) Remove obsolete .badge-pill class |
Description
Lucas Gass (lukeg)
2024-12-24 15:15:50 UTC
The problem I had with it is that returned items have alternating shades of grey and white line by line, but items still checked out alternate between yellow and an effectively identical shade of grey to the grey in the returned item alternating lines. Returned items: white/grey Checked out items: yellow/grey So you can't tell the difference between an item that is grey because it's returned (and not white), and an item that is grey because it's checked out (and not yellow). This is especially unhelpful when you're trying to sort by checkout date and not return date. Furthermore, the green links ( #408540 ) on a yellow background ( #FFFFCC ) do not meet accessibility standards for color contrast. I don't love the yellow row highlighting. It is meaningless unless you happen to know it represents an on loan item. I think we should add a Bootstrap badge somewhere on the row with the text 'Checked out'. It already exists in the return date column. Maybe we can just make that a yellow bade, so it stands out more. What if it was with the title column, or the barcode column? The return date/checked out column is all the way over on the right side, very far away from the title. You would most likely be looking at the title in the first place, and it would just be faster to see the most relevant information all at one go. Created attachment 176540 [details]
Proposed change to Bootstrap badges
(In reply to Cheryl from comment #4) > What if it was with the title column, or the barcode column? The return > date/checked out column is all the way over on the right side, very far away > from the title. You would most likely be looking at the title in the first > place, and it would just be faster to see the most relevant information all > at one go. I do think the 'Return date' column makes the most sense. I uploaded an attachment of what that would look like. I don't love the idea of attaching it to a a column that has nothing to do with, return date/onloan status like title or barcode. We will attach that patch, adding it to 'Return date'. I am also going to CC some others to see what they think. Created attachment 176541 [details] [review] Bug 38783: Added "Checked out" badge for checked out items in the circulation history table. To test: 1. Make some checkout to a patron so they have a circulation history, with some items checked in and some still on loan. 2. Look at the patron's "Circulation history" table. There are four possible background colors for each row: #ffffff, #f3f4f4, #F9FAE0, and #FFFFCC. 3. Apply the patch, update the CSS (yarn build), and restart everything (restart_all). 4. Repeat steps 1-2, if needed. An orange/gold badge will appear under the "Return date" column of the table for items that have been checked out, and there will no longer be alternating, pale yellow rows. Created attachment 176542 [details] [review] Bug 38783: Added "Checked out" badge for checked out items in the circulation history table. To test: 1. Make some checkout to a patron so they have a circulation history, with some items checked in and some still on loan. 2. Look at the patron's "Circulation history" table. There are four possible background colors for each row: #ffffff, #f3f4f4, #F9FAE0, and #FFFFCC. 3. Apply the patch, update the CSS (yarn build), and restart everything (restart_all). 4. Repeat steps 1-2, if needed. An orange/gold badge will appear under the "Return date" column of the table for items that have been checked out, and there will no longer be alternating, pale yellow rows. Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. I agree that it looks better now than before, and that it is easier to tell the checked out items from the returned items. Created attachment 176647 [details] [review] Bug 38783: Added "Checked out" badge for checked out items in the circulation history table. To test: 1. Make some checkout to a patron so they have a circulation history, with some items checked in and some still on loan. 2. Look at the patron's "Circulation history" table. There are four possible background colors for each row: #ffffff, #f3f4f4, #F9FAE0, and #FFFFCC. 3. Apply the patch, update the CSS (yarn build), and restart everything (restart_all). 4. Repeat steps 1-2, if needed. An orange/gold badge will appear under the "Return date" column of the table for items that have been checked out, and there will no longer be alternating, pale yellow rows. Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. I agree that it looks better now than before, and that it is easier to tell the checked out items from the returned items. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 176648 [details] [review] Bug 38783: (follow-up) Remove obsolete .badge-pill class .badge-pill is from a previous version of Bootstrap. .rounded-pill is the current version, but I think it looks better without. Created attachment 176944 [details] [review] Bug 38783: Added "Checked out" badge for checked out items in the circulation history table. To test: 1. Make some checkout to a patron so they have a circulation history, with some items checked in and some still on loan. 2. Look at the patron's "Circulation history" table. There are four possible background colors for each row: #ffffff, #f3f4f4, #F9FAE0, and #FFFFCC. 3. Apply the patch, update the CSS (yarn build), and restart everything (restart_all). 4. Repeat steps 1-2, if needed. An orange/gold badge will appear under the "Return date" column of the table for items that have been checked out, and there will no longer be alternating, pale yellow rows. Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. I agree that it looks better now than before, and that it is easier to tell the checked out items from the returned items. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 176945 [details] [review] Bug 38783: (follow-up) Remove obsolete .badge-pill class .badge-pill is from a previous version of Bootstrap. .rounded-pill is the current version, but I think it looks better without. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Found bug 38954 when QAing this. Just to say that this is a great improvement! It's stuff like this, the small changes. Thanks! Pushed for 25.05! Well done everyone, thank you! Nice work everyone! Pushed to 24.11.x for 24.11.04 |