Summary: | Remove overflow scroll from batch patron modification | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Tools | Assignee: | Owen Leonard <oleonard> |
Status: | Pushed to stable --- | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, nick, pedro.amorim |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37730 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
25.05.00,24.11.04
|
|
Circulation function: | |||
Attachments: |
Bug 38870: Remove overflow scroll from batch patron modification
Bug 38870: Remove overflow scroll from batch patron modification Bug 38870: Remove overflow scroll from batch patron modification |
Description
Owen Leonard
2025-01-13 12:59:32 UTC
Created attachment 176437 [details] [review] Bug 38870: Remove overflow scroll from batch patron modification This patch removes the <div> surrounding batch patron modification results with the style "overflow:auto". Also removed is the DataTable option "scrollX". This eliminates the horizontal scrolling for the table itself, and causes the whole page to scroll horizontally instead. This is consistent with other pages in Koha. This fix lets us avoid bugs which are associated with the overflow scrolling and our DataTables implementation. (see Bug 37730). To test, apply the patch and go to Tools -> Batch patron modification - Submit a batch of patrons for modification. - On the screen showing the patrons which will be modified, the page will probably have a horizontal scrollbar already. If not, resize your browser to confirm that the whole page scrolls, not just the table. - Confirm that the table header "sticks" to the top of the screen when you scroll down, and that the header continues to be aligned correctly when you scroll horizontally. Sponsored-by: Athens County Public Libraries scrollX's behaviour is better than this. But at least it's now consistent for all the other tables. If we want to fix that globally we should investigate a bit better how to fix this problem. For now I would vote for consistency and +1 Owen's patch. Created attachment 176451 [details] [review] Bug 38870: Remove overflow scroll from batch patron modification This patch removes the <div> surrounding batch patron modification results with the style "overflow:auto". Also removed is the DataTable option "scrollX". This eliminates the horizontal scrolling for the table itself, and causes the whole page to scroll horizontally instead. This is consistent with other pages in Koha. This fix lets us avoid bugs which are associated with the overflow scrolling and our DataTables implementation. (see Bug 37730). To test, apply the patch and go to Tools -> Batch patron modification - Submit a batch of patrons for modification. - On the screen showing the patrons which will be modified, the page will probably have a horizontal scrollbar already. If not, resize your browser to confirm that the whole page scrolls, not just the table. - Confirm that the table header "sticks" to the top of the screen when you scroll down, and that the header continues to be aligned correctly when you scroll horizontally. Sponsored-by: Athens County Public Libraries Signed-off-by: William Lavoie <william.lavoie@inLibro.com> Created attachment 176947 [details] [review] Bug 38870: Remove overflow scroll from batch patron modification This patch removes the <div> surrounding batch patron modification results with the style "overflow:auto". Also removed is the DataTable option "scrollX". This eliminates the horizontal scrolling for the table itself, and causes the whole page to scroll horizontally instead. This is consistent with other pages in Koha. This fix lets us avoid bugs which are associated with the overflow scrolling and our DataTables implementation. (see Bug 37730). To test, apply the patch and go to Tools -> Batch patron modification - Submit a batch of patrons for modification. - On the screen showing the patrons which will be modified, the page will probably have a horizontal scrollbar already. If not, resize your browser to confirm that the whole page scrolls, not just the table. - Confirm that the table header "sticks" to the top of the screen when you scroll down, and that the header continues to be aligned correctly when you scroll horizontally. Sponsored-by: Athens County Public Libraries Signed-off-by: William Lavoie <william.lavoie@inLibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> We didn't get feedback from the people involved on bug 37730 so I am passing QA on this. Pushed for 25.05! Well done everyone, thank you! Nice work everyone! Pushed to 24.11.x for 24.11.04 |