Bug 38964

Summary: Fix column span in footer of staff interface account payment page
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: Pushed to stable --- QA Contact: Lucas Gass (lukeg) <lucas>
Severity: minor    
Priority: P5 - low CC: aude.charillon, bdaeuber, cbrannon, david, fridolin.somers, jonathan.druart, katrin.fischer, lucas, lucy.vaux-harvey
Version: MainKeywords: rel_24_11_candidate
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39526
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
This fixes an alignment problem on the 'Make a payment' screen where the table footer had an inconsistent number of columns.
Version(s) released in:
25.05.00,24.11.09
Circulation function:
Bug Depends on: 33137    
Bug Blocks:    
Attachments: Bug 38964: Fix column span in footer of staff interface account payment page
Bug 38964: Fix column span in footer of staff interface account payment page
Bug 38964: Fix column span in footer of staff interface account payment page

Description Owen Leonard 2025-01-24 16:08:53 UTC
The footer of the table of charges on the account payment page has incorrect column spans, resulting in the rows having incorrect alignment.
Comment 1 Owen Leonard 2025-01-24 16:20:18 UTC
Created attachment 177128 [details] [review]
Bug 38964: Fix column span in footer of staff interface account payment page

This patch fixes the column span in the table footer rows of the account
payment page (pay.tt). I've also added a couple of lines of CSS to style
the footer rows.

To test, apply the patch and rebuild the staff interface CSS.

- In the staff client, locate a patron with charges.
- If necessary, go to a patrons "Accounting" tab and use the "Create
  manual invoice" page to add one or more charges to the account.
- Under the "Make a payment" tab there should be one or more footer rows
  including "Total due." The "Total due" cell should be aligned right,
  with a grey background.

Sponsored-by: Athens County Public Libraries
Comment 2 Phil Ringnalda 2025-01-24 17:39:28 UTC
Created attachment 177129 [details] [review]
Bug 38964: Fix column span in footer of staff interface account payment page

This patch fixes the column span in the table footer rows of the account
payment page (pay.tt). I've also added a couple of lines of CSS to style
the footer rows.

To test, apply the patch and rebuild the staff interface CSS.

- In the staff client, locate a patron with charges.
- If necessary, go to a patrons "Accounting" tab and use the "Create
  manual invoice" page to add one or more charges to the account.
- Under the "Make a payment" tab there should be one or more footer rows
  including "Total due." The "Total due" cell should be aligned right,
  with a grey background.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 3 Lucas Gass (lukeg) 2025-01-30 18:13:09 UTC
Created attachment 177358 [details] [review]
Bug 38964: Fix column span in footer of staff interface account payment page

This patch fixes the column span in the table footer rows of the account
payment page (pay.tt). I've also added a couple of lines of CSS to style
the footer rows.

To test, apply the patch and rebuild the staff interface CSS.

- In the staff client, locate a patron with charges.
- If necessary, go to a patrons "Accounting" tab and use the "Create
  manual invoice" page to add one or more charges to the account.
- Under the "Make a payment" tab there should be one or more footer rows
  including "Total due." The "Total due" cell should be aligned right,
  with a grey background.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Katrin Fischer 2025-01-31 14:58:14 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 5 Aude Charillon 2025-03-26 17:43:57 UTC
I believe this is also an issue in versions 24.11 and 23.11: when the Payment note column is hidden, the Total due value disappears.
Comment 6 Jonathan Druart 2025-07-15 08:39:32 UTC
*** Bug 40147 has been marked as a duplicate of this bug. ***
Comment 7 Katrin Fischer 2025-08-22 14:40:45 UTC
Wonder if this has slipped through with the release of 25.05/change of maints?
Comment 8 Lucas Gass (lukeg) 2025-08-28 16:24:09 UTC
*** Bug 40721 has been marked as a duplicate of this bug. ***
Comment 9 Christopher Brannon 2025-08-28 16:26:43 UTC
Can this be backported to 24.11?
Comment 10 Christopher Brannon 2025-08-28 19:17:49 UTC
Workaround until backported:

  //Workaround for bug 177358 - Fixing payment tab in patron accounting
  $('#pat_pay #finest td.total').attr('colspan','14');
Comment 11 Lucy Vaux-Harvey 2025-08-29 14:38:26 UTC
+1 for the workaround Christopher, much appreciated.
Comment 12 Fridolin Somers 2025-09-17 13:32:15 UTC
Pushed to 24.11.x for 24.11.09