Bug 38985

Summary: Syndetics covers don't show on OPAC result pages
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: CirculationAssignee: David Cook <dcook>
Status: Pushed to stable --- QA Contact: Lucas Gass (lukeg) <lucas>
Severity: normal    
Priority: P5 - low CC: barbara.johnson, david, dcook, gmcharlt, kyle.m.hall, oleonard
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00,24.11.02
Circulation function:
Bug Depends on: 26933    
Bug Blocks:    
Attachments: Bug 38985: Add correct check before adding Syndetics covers
Bug 38985: Add correct check before adding Syndetics covers
Bug 38985: Only test normalized_isbn for OPAC Syndetics covers
Bug 38985: Add correct check before adding Syndetics covers
Bug 38985: Only test normalized_isbn for OPAC Syndetics covers
Bug 38985: Add correct check before adding Syndetics covers
Bug 38985: Only test normalized_isbn for OPAC Syndetics covers

Description Lucas Gass (lukeg) 2025-01-28 15:31:43 UTC
To recreate:

1. Enable Syndetics.  
2. Do a search that should turn up Syndetics. ( In k-t-d a search of 'ee' works for me. Turning up biblionumber 55 )
3. Visit the record detail page and notice the Syndetics cover loads.
Comment 1 Lucas Gass (lukeg) 2025-01-28 15:32:47 UTC
I don't think `content_identifier_exists` is something that ever gets passed to the OPAC results page.
Comment 2 Barbara Johnson 2025-01-28 16:21:19 UTC
I attempted to test in a sandbox but when I applied the patch it gave me the error 'No patches on bug 38985'  

Also, in the test plan under #3 I think it should say 'Visit the results page' instead of the 'detail page' because the problem is on opac-search.pl instead of on opac-detail.pl.
Comment 3 Barbara Johnson 2025-01-28 16:22:54 UTC
And I was going to set the status to 'Failed QA' but that is not included in the dropdown so I couldn't do that.
Comment 4 David Nind 2025-01-28 18:39:27 UTC
There is no patch yet 8-) (The steps in the description are just describing how to reproduce the issue.)
Comment 5 Lucas Gass (lukeg) 2025-01-28 20:23:26 UTC
Created attachment 177293 [details] [review]
Bug 38985: Add correct check before adding Syndetics covers

To test:
1. Enable Syndetics.
2. Do a search that should turn up Syndetics. ( In k-t-d a search of 'ee' works for me. Turning up biblionumber 55 )
3. Visit the record detail page and notice the Syndetics cover loads.
4. APPLY PATCH
5. Try again, this time the Syndetics covers should load.
6. Since these are now in an include make sure Syndetics covers load on opac results, opac detail, staff results, and staff detail.
7. Try with Syndetics and other cover image services enabled.
Comment 6 PTFS Europe Sandboxes 2025-01-28 21:03:42 UTC
Created attachment 177297 [details] [review]
Bug 38985: Add correct check before adding Syndetics covers

To test:
1. Enable Syndetics.
2. Do a search that should turn up Syndetics. ( In k-t-d a search of 'ee' works for me. Turning up biblionumber 55 )
3. Visit the record detail page and notice the Syndetics cover loads.
4. APPLY PATCH
5. Try again, this time the Syndetics covers should load.
6. Since these are now in an include make sure Syndetics covers load on opac results, opac detail, staff results, and staff detail.
7. Try with Syndetics and other cover image services enabled.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 7 Barbara Johnson 2025-01-28 21:10:43 UTC
Syndetics cover images loaded on all results and detail pages in both the OPAC and staff interface. I paged through a search that that had 225 results and the cover images displayed on all pages in the results set. They displayed in a patron account on the OPAC. Multiple cover images worked as well.

Thanks for the patch.
Comment 8 David Cook 2025-01-28 22:52:29 UTC
I don't have a Syndetics code to use, so I don't think that I can test this.

However... I think the patch might be incorrect. If you look at C4/Search.pm and koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt, it looks like the patch should change "content_identifier_exists" to "SEARCH_RESULT.content_identifier_exists"
Comment 9 David Cook 2025-01-28 22:52:48 UTC
I'll upload a patch for that and then you folk can test it out?
Comment 10 David Cook 2025-01-28 22:55:33 UTC
Actually... as I say that... I think that's wrong too.

The Syndetics code requires SEARCH_RESULT.normalized_isbn. Like OPACCoce, it should just be using that as a test.
Comment 11 David Cook 2025-01-28 22:56:28 UTC
Created attachment 177298 [details] [review]
Bug 38985: Only test normalized_isbn for OPAC Syndetics covers
Comment 12 PTFS Europe Sandboxes 2025-01-29 22:22:06 UTC
Created attachment 177326 [details] [review]
Bug 38985: Add correct check before adding Syndetics covers

To test:
1. Enable Syndetics.
2. Do a search that should turn up Syndetics. ( In k-t-d a search of 'ee' works for me. Turning up biblionumber 55 )
3. Visit the record detail page and notice the Syndetics cover loads.
4. APPLY PATCH
5. Try again, this time the Syndetics covers should load.
6. Since these are now in an include make sure Syndetics covers load on opac results, opac detail, staff results, and staff detail.
7. Try with Syndetics and other cover image services enabled.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 13 PTFS Europe Sandboxes 2025-01-29 22:22:09 UTC
Created attachment 177327 [details] [review]
Bug 38985: Only test normalized_isbn for OPAC Syndetics covers

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 14 Barbara Johnson 2025-01-29 22:22:39 UTC
Everything worked fine for me.
Comment 15 Lucas Gass (lukeg) 2025-01-29 22:55:41 UTC
Created attachment 177328 [details] [review]
Bug 38985: Add correct check before adding Syndetics covers

To test:
1. Enable Syndetics.
2. Do a search that should turn up Syndetics. ( In k-t-d a search of 'ee' works for me. Turning up biblionumber 55 )
3. Visit the record detail page and notice the Syndetics cover loads.
4. APPLY PATCH
5. Try again, this time the Syndetics covers should load.
6. Since these are now in an include make sure Syndetics covers load on opac results, opac detail, staff results, and staff detail.
7. Try with Syndetics and other cover image services enabled.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 16 Lucas Gass (lukeg) 2025-01-29 22:55:44 UTC
Created attachment 177329 [details] [review]
Bug 38985: Only test normalized_isbn for OPAC Syndetics covers

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 17 Katrin Fischer 2025-01-30 17:56:19 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 18 Paul Derscheid 2025-02-04 21:54:59 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.02