Bug 39582 - Syndetics covers don't show on OPAC result pages when identifier is not ISBN
Summary: Syndetics covers don't show on OPAC result pages when identifier is not ISBN
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Brendan Lawlor
URL:
Keywords:
Depends on: 38985
Blocks:
  Show dependency treegraph
 
Reported: 2025-04-08 14:39 UTC by Lucas Gass (lukeg)
Modified: 2025-05-08 06:01 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39582: Syndetics support for UPC and OCLC numbers on OPAC results page (2.68 KB, patch)
2025-04-30 16:00 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 39582: Syndetics support for UPC and OCLC numbers on OPAC results page (2.74 KB, patch)
2025-04-30 16:33 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 39582: Syndetics support for UPC and OCLC numbers on OPAC results page (2.79 KB, patch)
2025-05-07 16:26 UTC, Brendan Lawlor
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2025-04-08 14:39:58 UTC
Related to Bug 38985. Syndetics cover images now show on the results page when the identifier is ISBN. If it is something else they images do not show:

To recreate:
1. Enable Syndetics 
2. Have a record with an 024 and 1st indicator.
3. Do a search to return the record from step 3. 
4. The image does not display.
Comment 1 Lucas Gass (lukeg) 2025-04-30 16:00:13 UTC
Created attachment 181719 [details] [review]
Bug 39582: Syndetics support for UPC and OCLC numbers on OPAC results page

To test:
1. Enable Syndetics
2. Have a record with an 024 and 1st indicator.
3. Do a search to return the record from step 3.
4. The image does not display.
5. APPLY PATCH
6. Try step 3 again, this time the cover image should display properly on the OPAC results page.
Comment 2 PTFS Europe Sandboxes 2025-04-30 16:33:50 UTC
Created attachment 181721 [details] [review]
Bug 39582: Syndetics support for UPC and OCLC numbers on OPAC results page

To test:
1. Enable Syndetics
2. Have a record with an 024 and 1st indicator.
3. Do a search to return the record from step 3.
4. The image does not display.
5. APPLY PATCH
6. Try step 3 again, this time the cover image should display properly on the OPAC results page.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 3 Barbara Johnson 2025-04-30 16:34:41 UTC
Worked as expected
Comment 4 Brendan Lawlor 2025-05-07 16:26:11 UTC
Created attachment 182035 [details] [review]
Bug 39582: Syndetics support for UPC and OCLC numbers on OPAC results page

To test:
1. Enable Syndetics
2. Have a record with an 024 and 1st indicator.
3. Do a search to return the record from step 3.
4. The image does not display.
5. APPLY PATCH
6. Try step 3 again, this time the cover image should display properly on the OPAC results page.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Comment 5 Brendan Lawlor 2025-05-07 16:41:29 UTC
This patch works as described, makes sense, and the QA script is happy. Passing QA. Nice!

QA test notes:

This patch works the same way as it currently does in the staff interface:
git grep -n 'normalized_oclc' -- koha-tmpl/intranet-tmpl/prog/en/modules/cat
alogue/results.tt 

See lines 612 and 616.

To test UPC number you can use this example:
Add 024 first indicator 1 subfield a 043396632905

To test OCLC number remove the UPC and use this example:
Add 035 subfield a (OCoLC)32744417
Comment 6 Katrin Fischer 2025-05-08 06:01:22 UTC
Pushed for 25.05!

Well done everyone, thank you!