To recreate: 1. Enable Syndetics. 2. Do a search that should turn up Syndetics. ( In k-t-d a search of 'ee' works for me. Turning up biblionumber 55 ) 3. Visit the record detail page and notice the Syndetics cover loads.
I don't think `content_identifier_exists` is something that ever gets passed to the OPAC results page.
I attempted to test in a sandbox but when I applied the patch it gave me the error 'No patches on bug 38985' Also, in the test plan under #3 I think it should say 'Visit the results page' instead of the 'detail page' because the problem is on opac-search.pl instead of on opac-detail.pl.
And I was going to set the status to 'Failed QA' but that is not included in the dropdown so I couldn't do that.
There is no patch yet 8-) (The steps in the description are just describing how to reproduce the issue.)
Created attachment 177293 [details] [review] Bug 38985: Add correct check before adding Syndetics covers To test: 1. Enable Syndetics. 2. Do a search that should turn up Syndetics. ( In k-t-d a search of 'ee' works for me. Turning up biblionumber 55 ) 3. Visit the record detail page and notice the Syndetics cover loads. 4. APPLY PATCH 5. Try again, this time the Syndetics covers should load. 6. Since these are now in an include make sure Syndetics covers load on opac results, opac detail, staff results, and staff detail. 7. Try with Syndetics and other cover image services enabled.
Created attachment 177297 [details] [review] Bug 38985: Add correct check before adding Syndetics covers To test: 1. Enable Syndetics. 2. Do a search that should turn up Syndetics. ( In k-t-d a search of 'ee' works for me. Turning up biblionumber 55 ) 3. Visit the record detail page and notice the Syndetics cover loads. 4. APPLY PATCH 5. Try again, this time the Syndetics covers should load. 6. Since these are now in an include make sure Syndetics covers load on opac results, opac detail, staff results, and staff detail. 7. Try with Syndetics and other cover image services enabled. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Syndetics cover images loaded on all results and detail pages in both the OPAC and staff interface. I paged through a search that that had 225 results and the cover images displayed on all pages in the results set. They displayed in a patron account on the OPAC. Multiple cover images worked as well. Thanks for the patch.
I don't have a Syndetics code to use, so I don't think that I can test this. However... I think the patch might be incorrect. If you look at C4/Search.pm and koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt, it looks like the patch should change "content_identifier_exists" to "SEARCH_RESULT.content_identifier_exists"
I'll upload a patch for that and then you folk can test it out?
Actually... as I say that... I think that's wrong too. The Syndetics code requires SEARCH_RESULT.normalized_isbn. Like OPACCoce, it should just be using that as a test.
Created attachment 177298 [details] [review] Bug 38985: Only test normalized_isbn for OPAC Syndetics covers
Created attachment 177326 [details] [review] Bug 38985: Add correct check before adding Syndetics covers To test: 1. Enable Syndetics. 2. Do a search that should turn up Syndetics. ( In k-t-d a search of 'ee' works for me. Turning up biblionumber 55 ) 3. Visit the record detail page and notice the Syndetics cover loads. 4. APPLY PATCH 5. Try again, this time the Syndetics covers should load. 6. Since these are now in an include make sure Syndetics covers load on opac results, opac detail, staff results, and staff detail. 7. Try with Syndetics and other cover image services enabled. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Created attachment 177327 [details] [review] Bug 38985: Only test normalized_isbn for OPAC Syndetics covers Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Everything worked fine for me.
Created attachment 177328 [details] [review] Bug 38985: Add correct check before adding Syndetics covers To test: 1. Enable Syndetics. 2. Do a search that should turn up Syndetics. ( In k-t-d a search of 'ee' works for me. Turning up biblionumber 55 ) 3. Visit the record detail page and notice the Syndetics cover loads. 4. APPLY PATCH 5. Try again, this time the Syndetics covers should load. 6. Since these are now in an include make sure Syndetics covers load on opac results, opac detail, staff results, and staff detail. 7. Try with Syndetics and other cover image services enabled. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177329 [details] [review] Bug 38985: Only test normalized_isbn for OPAC Syndetics covers Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Pushed for 25.05! Well done everyone, thank you!
Nice work everyone! Pushed to 24.11.x for 24.11.02