Summary: | "Encoding errors" block on detail page hurt the eyes | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Staff interface | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | Pushed to stable --- | QA Contact: | Owen Leonard <oleonard> |
Severity: | normal | ||
Priority: | P5 - low | CC: | baptiste.wojtkowski, david, dcook, gmcharlt, katrin.fischer, lucas, martin.renvoize, nick, oleonard, pedro.amorim |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.05.00,24.11.08
|
Circulation function: | |
Bug Depends on: | 38519, 35402 | ||
Bug Blocks: | |||
Attachments: |
Bug 39000: Restore bg-danger color
Bug 39000: Restore bg-danger color Bug 39000: Restore bg-danger color |
Description
Jonathan Druart
2025-01-30 09:22:11 UTC
We lost this: -.bg-danger { - background-color: #f2dede -} Created attachment 177349 [details] [review] Bug 39000: Restore bg-danger color In ktd 369 will show the "Encoding error" block: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=369 The background color has changed this the bootstrap update and now looks ugly. This patch reuse the same color (#f2dede) we had before the upgrade Created attachment 177369 [details] [review] Bug 39000: Restore bg-danger color In ktd 369 will show the "Encoding error" block: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=369 The background color has changed this the bootstrap update and now looks ugly. This patch reuse the same color (#f2dede) we had before the upgrade Signed-off-by: David Nind <david@davidnind.com> I've signed off and added related bug 38519. Shouldn't the class be changed to match the Bootstrap 5 classes?[1] Will leave Owen to comment on that! Changes to classes - screenshot of the colours: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174935 David Testing notes: 1. After applying the patch, rebuild the css: yarn build Created attachment 177575 [details] [review] Bug 39000: Restore bg-danger color In ktd 369 will show the "Encoding error" block: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=369 The background color has changed this the bootstrap update and now looks ugly. This patch reuse the same color (#f2dede) we had before the upgrade Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> This does look much better - we could use $red-100 instead if we want to stick with the defined colors, but others have specific values too so seems okay *** Bug 39102 has been marked as a duplicate of this bug. *** Pushed for 25.05! Well done everyone, thank you! Pushed into 24.11.x for 24.11.08 nice work everyone. No eyes will be hurt anymore This causes the red to be barely readable when used in the text-danger context. For reference, visit the following: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=IndependentBranches&ok=Search You can't read the warning under 'IndependentBranches' anymore. As this has already been released, should we move to a new bug for further fixes? (In reply to Katrin Fischer from comment #11) > As this has already been released, should we move to a new bug for further > fixes? I encountered this on 24.11.x. It appears main has this fixed from bug 39274. |