Bug 39274 - Non public notes are low contrast in the issues table - Previous checkouts
Summary: Non public notes are low contrast in the issues table - Previous checkouts
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-03-07 16:02 UTC by Lucas Gass (lukeg)
Modified: 2025-03-25 16:12 UTC (History)
10 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 39274: Non public notes are low contrast in the issues table - Previous checkouts (27.64 KB, patch)
2025-03-17 11:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39274: Non public notes are low contrast in the issues table - Previous checkouts (27.63 KB, patch)
2025-03-18 11:47 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39274: Non public notes are low contrast in the issues table - Previous checkouts (26.92 KB, patch)
2025-03-25 16:12 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2025-03-07 16:02:17 UTC
To recreate:

1. Have an item with a non-public note. 
2. Check it out, it looks fine while under "Today's issues"
3. Set the issuedate to some time in the past ( update issues set issuedate = '2025-03-04 15:58:46'; )
4. Now the not shows very low contrast.
Comment 1 Christopher Brannon 2025-03-13 21:16:55 UTC
Yep, we're running into this too.
Comment 2 susan.reynolds 2025-03-14 19:09:52 UTC
Yes, also running into this issue.
Comment 3 Andrew Fuerste-Henry 2025-03-14 19:10:24 UTC
Seems relevant here that the text on the IndependentBranches syspref also has the class 'text-danger' and is also showing this low contrast color.
Comment 4 Owen Leonard 2025-03-17 11:48:53 UTC
Created attachment 179389 [details] [review]
Bug 39274: Non public notes are low contrast in the issues table - Previous checkouts

This patch reflects some rethinking on my part about how the Bootstrap
color classes are meant to be used, and makes some changes which I hope
will be more consistent with the Bootstrap 5 documentation while keeping
our interface usable.

The main difference is in the use of the classes "text-bg-*" and
"bg-*-subtle." For example the class "bg-info-subtle" will give an
element a subtle colored background. "text-bg-info" will have a more
saturated background color. The "text-" part of the class is a reference
to the fact that elements with that category of classes will have text
color which adapts to provide correct contrast.

This patch also makes a minor adjustment to the color used for "warning"
type elements (e.g. <div class="alert alert-warning">. I've adjusted the
color slightly in order to differentiate it from the "primary"
class color we use for submit buttons.

To test, apply the patch and rebuil the staff interface CSS. Clear your
browser cache if necessary.

Checkouts:
1. Have an item with a non-public note.
2. Check it out, it looks fine while under "Today's issues"
3. Set the issuedate to some time in the past
   `update issues set issuedate = '2025-03-04 15:58:46';`
4. The non-public note should appear in legible red.

Return claims:
1. The "Claims" tab on the patron detail and checkout pages already used
   the "text-bg-*" classes but the "-success" class didn't work well
   with the tab background color so I removed it. I notice there is a bug
   in the way the classes change as the tab is activated, but that will
   have to be dealt with on another bug.

Bibliographic details:
1. Place at least one hold and at least one article request on a title.
2. The detail view should show "Holds: 1", and "Article requests: 1"
   with the numbers in legible Bootstrap badges.

Holds:
1. Perform a catalog search which will return multiple titles.
2. Select multiple titles and click "Place hold."
3. Select a patron to place a hold for.
4. Confirm the holds by clicking "Place hold."
5. The holds should now be shown under the heading "Existing holds,"
   with Bootstrap badgets showing the hold count on each.

Patrons requesting modification:
1. Submit an update to a patron record via the OPAC.
2. On the patrons home page in the staff interface there should be a
   "Patrons requesting modifications" link at the top, with a count of
   pending modifications shown in a Bootstrap badge.

Check-ins:
1. Check in an item from a patron account with multiple other checkouts.
2. In the table of checked-in items the patron's remaining checkout
   count should be shown in a Bootstrap badge.

SMTP servers:
1. Go to Administration -> SMTP Servers.
2. Edit at least one server so that debug mode is enabled and it is
   marked as a default server.
3. In the view of servers, the debug mode and default status should be
   shown in Bootstrap badges.

Plugins:
1. Go to Administration -> Plugins.
2. Upload a plugin if necessary, and check the list of installed plugins
   when the plugin is disabled and when it is enabled. In both cases the
   status should appear in a Bootstrap badge.

About page:
1. Go to the About page.
2. Under the "Server information" tab, the status of Memcached and
   Message broker should be shown with a background color--pale blue for
   okay statuses.

Tools home page:
1. If necessary, go to the OPAC and submit at least one comment on a
   bibliographic record and tag at least one record.
2. In the staff interface, on the Tools home page, the number of tags
   pending approval and the number of comments awaiting moderation
   should show in Bootstrap badges.

Sponsored-by: Athens County Public Libraries
Comment 5 David Nind 2025-03-17 18:59:18 UTC
The patch no longer applies 8-(...

git bz apply 39274

Bug 39274 - Non public notes are low contrast in the issues table - Previous checkouts

179389 - Bug 39274: Non public notes are low contrast in the issues table - Previous checkouts

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 39274: Non public notes are low contrast in the issues table - Previous checkouts
Using index info to reconstruct a base tree...
M	koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
M	koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
M	koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
M	koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
error: Failed to merge in the changes.
Patch failed at 0001 Bug 39274: Non public notes are low contrast in the issues table - Previous checkouts

Testing notes (using KTD):

1. For claim returned testing:
   - Set a value for the ClaimReturnedLostValue system preference
   - On the patron's check out section, change the columns so that the "Return claimed" one is selected, then the "Claim returned" button is shown

2. Tools home page - tags:
   - To show the badge for tags requring moderation, set the TagsModeration system preference to "Require"
Comment 6 Owen Leonard 2025-03-18 11:47:41 UTC
Created attachment 179448 [details] [review]
Bug 39274: Non public notes are low contrast in the issues table - Previous checkouts

This patch reflects some rethinking on my part about how the Bootstrap
color classes are meant to be used, and makes some changes which I hope
will be more consistent with the Bootstrap 5 documentation while keeping
our interface usable.

The main difference is in the use of the classes "text-bg-*" and
"bg-*-subtle." For example the class "bg-info-subtle" will give an
element a subtle colored background. "text-bg-info" will have a more
saturated background color. The "text-" part of the class is a reference
to the fact that elements with that category of classes will have text
color which adapts to provide correct contrast.

This patch also makes a minor adjustment to the color used for "warning"
type elements (e.g. <div class="alert alert-warning">. I've adjusted the
color slightly in order to differentiate it from the "primary"
class color we use for submit buttons.

To test, apply the patch and rebuil the staff interface CSS. Clear your
browser cache if necessary.

Checkouts:
1. Have an item with a non-public note.
2. Check it out, it looks fine while under "Today's issues"
3. Set the issuedate to some time in the past
   `update issues set issuedate = '2025-03-04 15:58:46';`
4. The non-public note should appear in legible red.

Return claims:
1. The "Claims" tab on the patron detail and checkout pages already used
   the "text-bg-*" classes but the "-success" class didn't work well
   with the tab background color so I removed it. I notice there is a bug
   in the way the classes change as the tab is activated, but that will
   have to be dealt with on another bug.

Bibliographic details:
1. Place at least one hold and at least one article request on a title.
2. The detail view should show "Holds: 1", and "Article requests: 1"
   with the numbers in legible Bootstrap badges.

Holds:
1. Perform a catalog search which will return multiple titles.
2. Select multiple titles and click "Place hold."
3. Select a patron to place a hold for.
4. Confirm the holds by clicking "Place hold."
5. The holds should now be shown under the heading "Existing holds,"
   with Bootstrap badgets showing the hold count on each.

Patrons requesting modification:
1. Submit an update to a patron record via the OPAC.
2. On the patrons home page in the staff interface there should be a
   "Patrons requesting modifications" link at the top, with a count of
   pending modifications shown in a Bootstrap badge.

Check-ins:
1. Check in an item from a patron account with multiple other checkouts.
2. In the table of checked-in items the patron's remaining checkout
   count should be shown in a Bootstrap badge.

SMTP servers:
1. Go to Administration -> SMTP Servers.
2. Edit at least one server so that debug mode is enabled and it is
   marked as a default server.
3. In the view of servers, the debug mode and default status should be
   shown in Bootstrap badges.

Plugins:
1. Go to Administration -> Plugins.
2. Upload a plugin if necessary, and check the list of installed plugins
   when the plugin is disabled and when it is enabled. In both cases the
   status should appear in a Bootstrap badge.

About page:
1. Go to the About page.
2. Under the "Server information" tab, the status of Memcached and
   Message broker should be shown with a background color--pale blue for
   okay statuses.

Tools home page:
1. If necessary, go to the OPAC and submit at least one comment on a
   bibliographic record and tag at least one record.
2. In the staff interface, on the Tools home page, the number of tags
   pending approval and the number of comments awaiting moderation
   should show in Bootstrap badges.

Sponsored-by: Athens County Public Libraries
Comment 7 Andrew Fuerste-Henry 2025-03-25 16:12:52 UTC
Created attachment 179695 [details] [review]
Bug 39274: Non public notes are low contrast in the issues table - Previous checkouts

This patch reflects some rethinking on my part about how the Bootstrap
color classes are meant to be used, and makes some changes which I hope
will be more consistent with the Bootstrap 5 documentation while keeping
our interface usable.

The main difference is in the use of the classes "text-bg-*" and
"bg-*-subtle." For example the class "bg-info-subtle" will give an
element a subtle colored background. "text-bg-info" will have a more
saturated background color. The "text-" part of the class is a reference
to the fact that elements with that category of classes will have text
color which adapts to provide correct contrast.

This patch also makes a minor adjustment to the color used for "warning"
type elements (e.g. <div class="alert alert-warning">. I've adjusted the
color slightly in order to differentiate it from the "primary"
class color we use for submit buttons.

To test, apply the patch and rebuil the staff interface CSS. Clear your
browser cache if necessary.

Checkouts:
1. Have an item with a non-public note.
2. Check it out, it looks fine while under "Today's issues"
3. Set the issuedate to some time in the past
   `update issues set issuedate = '2025-03-04 15:58:46';`
4. The non-public note should appear in legible red.

Return claims:
1. The "Claims" tab on the patron detail and checkout pages already used
   the "text-bg-*" classes but the "-success" class didn't work well
   with the tab background color so I removed it. I notice there is a bug
   in the way the classes change as the tab is activated, but that will
   have to be dealt with on another bug.

Bibliographic details:
1. Place at least one hold and at least one article request on a title.
2. The detail view should show "Holds: 1", and "Article requests: 1"
   with the numbers in legible Bootstrap badges.

Holds:
1. Perform a catalog search which will return multiple titles.
2. Select multiple titles and click "Place hold."
3. Select a patron to place a hold for.
4. Confirm the holds by clicking "Place hold."
5. The holds should now be shown under the heading "Existing holds,"
   with Bootstrap badgets showing the hold count on each.

Patrons requesting modification:
1. Submit an update to a patron record via the OPAC.
2. On the patrons home page in the staff interface there should be a
   "Patrons requesting modifications" link at the top, with a count of
   pending modifications shown in a Bootstrap badge.

Check-ins:
1. Check in an item from a patron account with multiple other checkouts.
2. In the table of checked-in items the patron's remaining checkout
   count should be shown in a Bootstrap badge.

SMTP servers:
1. Go to Administration -> SMTP Servers.
2. Edit at least one server so that debug mode is enabled and it is
   marked as a default server.
3. In the view of servers, the debug mode and default status should be
   shown in Bootstrap badges.

Plugins:
1. Go to Administration -> Plugins.
2. Upload a plugin if necessary, and check the list of installed plugins
   when the plugin is disabled and when it is enabled. In both cases the
   status should appear in a Bootstrap badge.

About page:
1. Go to the About page.
2. Under the "Server information" tab, the status of Memcached and
   Message broker should be shown with a background color--pale blue for
   okay statuses.

Tools home page:
1. If necessary, go to the OPAC and submit at least one comment on a
   bibliographic record and tag at least one record.
2. In the staff interface, on the Tools home page, the number of tags
   pending approval and the number of comments awaiting moderation
   should show in Bootstrap badges.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>