Bug 39000 - "Encoding errors" block on detail page hurt the eyes
Summary: "Encoding errors" block on detail page hurt the eyes
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Owen Leonard
URL:
Keywords:
: 39102 (view as bug list)
Depends on: 38519 35402
Blocks:
  Show dependency treegraph
 
Reported: 2025-01-30 09:22 UTC by Jonathan Druart
Modified: 2025-02-11 23:01 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 39000: Restore bg-danger color (1.31 KB, patch)
2025-01-30 09:32 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 39000: Restore bg-danger color (1.35 KB, patch)
2025-01-30 21:54 UTC, David Nind
Details | Diff | Splinter Review
Bug 39000: Restore bg-danger color (1.41 KB, patch)
2025-02-06 14:11 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-01-30 09:22:11 UTC
https://snipboard.io/wUmV50.jpg
Comment 1 Jonathan Druart 2025-01-30 09:26:59 UTC
We lost this:

-.bg-danger {
-    background-color: #f2dede
-}
Comment 2 Jonathan Druart 2025-01-30 09:32:25 UTC
Created attachment 177349 [details] [review]
Bug 39000: Restore bg-danger color

In ktd 369 will show the "Encoding error" block:
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=369

The background color has changed this the bootstrap update and now looks
ugly.

This patch reuse the same color (#f2dede) we had before the upgrade
Comment 3 David Nind 2025-01-30 21:54:21 UTC
Created attachment 177369 [details] [review]
Bug 39000: Restore bg-danger color

In ktd 369 will show the "Encoding error" block:
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=369

The background color has changed this the bootstrap update and now looks
ugly.

This patch reuse the same color (#f2dede) we had before the upgrade

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2025-01-30 21:57:28 UTC
I've signed off and added related bug 38519.

Shouldn't the class be changed to match the Bootstrap 5 classes?[1] Will leave Owen to comment on that!

Changes to classes - screenshot of the colours:
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174935


David

Testing notes:
1. After applying the patch, rebuild the css: yarn build
Comment 5 Nick Clemens (kidclamp) 2025-02-06 14:11:25 UTC
Created attachment 177575 [details] [review]
Bug 39000: Restore bg-danger color

In ktd 369 will show the "Encoding error" block:
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=369

The background color has changed this the bootstrap update and now looks
ugly.

This patch reuse the same color (#f2dede) we had before the upgrade

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Nick Clemens (kidclamp) 2025-02-06 14:12:55 UTC
This does look much better - we could use $red-100 instead if we want to stick with the defined colors, but others have specific values too so seems okay
Comment 7 David Cook 2025-02-11 23:01:30 UTC
*** Bug 39102 has been marked as a duplicate of this bug. ***