Description
Owen Leonard
2025-02-10 18:59:24 UTC
Created attachment 177709 [details] [review] Bug 39081: Fix date and title sorting on batch extend due dates page This patch updates sorting of the batch extend due dates page so that dates and titles are sorted correctly. To test, apply the patch and go to Tools -> Batch extend due dates. - Submit parameters which will return multiple results - On the "Confirm selection" page, test the sorting of these columns: - Due date - Title - Checked out on - New due date Sponsored-by: Athens County Public Libraries Created attachment 177947 [details] [review] Bug 39081: Fix date and title sorting on batch extend due dates page This patch updates sorting of the batch extend due dates page so that dates and titles are sorted correctly. To test, apply the patch and go to Tools -> Batch extend due dates. - Submit parameters which will return multiple results - On the "Confirm selection" page, test the sorting of these columns: - Due date - Title - Checked out on - New due date Sponsored-by: Athens County Public Libraries Not sure what's happening but it's not working for me, at least for due dates: https://snipboard.io/kZD0qz.jpg ok, I found something. Created attachment 179122 [details] [review] Bug 39081: Fix order by due dates Created attachment 179123 [details] [review] Bug 39081: Adjust the result table Created attachment 179124 [details] [review] Bug 39081: Allow sort on item type There is no reason to not allow ordering on item type. We can now use the same parameters for both tables Not the end of the world, but it's a little odd to allow sorting by the column with the checkboxes when it doesn't actually sort the way you would hope, by whether or not they are checked. Created attachment 180192 [details] [review] Bug 39081: Fix date and title sorting on batch extend due dates page This patch updates sorting of the batch extend due dates page so that dates and titles are sorted correctly. To test, apply the patch and go to Tools -> Batch extend due dates. - Submit parameters which will return multiple results - On the "Confirm selection" page, test the sorting of these columns: - Due date - Title - Checked out on - New due date Sponsored-by: Athens County Public Libraries Signed-off-by: Magnus Enger <magnus@libriotech.no> Created attachment 180193 [details] [review] Bug 39081: Fix order by due dates Signed-off-by: Magnus Enger <magnus@libriotech.no> Created attachment 180194 [details] [review] Bug 39081: Adjust the result table Signed-off-by: Magnus Enger <magnus@libriotech.no> Created attachment 180195 [details] [review] Bug 39081: Allow sort on item type There is no reason to not allow ordering on item type. We can now use the same parameters for both tables Signed-off-by: Magnus Enger <magnus@libriotech.no> Created attachment 180845 [details] [review] Bug 39081: Fix date and title sorting on batch extend due dates page This patch updates sorting of the batch extend due dates page so that dates and titles are sorted correctly. To test, apply the patch and go to Tools -> Batch extend due dates. - Submit parameters which will return multiple results - On the "Confirm selection" page, test the sorting of these columns: - Due date - Title - Checked out on - New due date Sponsored-by: Athens County Public Libraries Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Created attachment 180846 [details] [review] Bug 39081: Fix order by due dates Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Created attachment 180847 [details] [review] Bug 39081: Adjust the result table Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Created attachment 180848 [details] [review] Bug 39081: Allow sort on item type There is no reason to not allow ordering on item type. We can now use the same parameters for both tables Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Created attachment 180960 [details] [review] Bug 39081: (follow-up) Use "data-order" instead of "data-sort" Both attribute names work the same but "data-order" is more frequent in our templates. Thanks Owen! With all the new datatables work, is there a place we should start documenting or updating documentation? Can you please rebase on latest main? Conflicts probably due to: Bug 38984 - DataTables's columnDefs cleanup Created attachment 181253 [details] [review] Bug 39081: Fix date and title sorting on batch extend due dates page This patch updates sorting of the batch extend due dates page so that dates and titles are sorted correctly. To test, apply the patch and go to Tools -> Batch extend due dates. - Submit parameters which will return multiple results - On the "Confirm selection" page, test the sorting of these columns: - Due date - Title - Checked out on - New due date Sponsored-by: Athens County Public Libraries Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Created attachment 181254 [details] [review] Bug 39081: Fix order by due dates Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Created attachment 181255 [details] [review] Bug 39081: Adjust the result table Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Created attachment 181256 [details] [review] Bug 39081: Allow sort on item type There is no reason to not allow ordering on item type. We can now use the same parameters for both tables Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Created attachment 181257 [details] [review] Bug 39081: (follow-up) Use "data-order" instead of "data-sort" Both attribute names work the same but "data-order" is more frequent in our templates. Thanks for the quick rebase, Owen! Pushed for 25.05! Well done everyone, thank you! |