Bug 39154

Summary: About: add a warning for obsoleted sip.log
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: AboutAssignee: Marcel de Rooy <m.de.rooy>
Status: Pushed to main --- QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: enhancement    
Priority: P5 - low CC: martin.renvoize
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Bug Depends on: 36954, 39153    
Bug Blocks:    
Attachments: Bug 39154: Add sip.log test in about
Bug 39154: Add sip.log test in about
Bug 39154: Add sip.log test in about

Description Marcel de Rooy 2025-02-18 13:22:03 UTC
See 36954.
Comment 1 Marcel de Rooy 2025-02-18 14:37:08 UTC
Created attachment 178275 [details] [review]
Bug 39154: Add sip.log test in about

See bug 36954. The file sip.log should not be found anymore in
log4perl.conf.

Test plan:
Edit log4perl.conf. Replace sip-output.log by sip.log.
Check About, tab sysinfo. You should see a warn.
Edit again. Switch back to sip-output.log.
Verify that there is no warn anymore on about.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 David Nind 2025-02-18 17:25:42 UTC
Created attachment 178293 [details] [review]
Bug 39154: Add sip.log test in about

See bug 36954. The file sip.log should not be found anymore in
log4perl.conf.

Test plan:
Edit log4perl.conf. Replace sip-output.log by sip.log.
Check About, tab sysinfo. You should see a warn.
Edit again. Switch back to sip-output.log.
Verify that there is no warn anymore on about.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2025-02-19 12:06:58 UTC
(In reply to David Nind from comment #2)
> Signed-off-by: David Nind <david@davidnind.com>

Thanks David!
Comment 4 Martin Renvoize (ashimema) 2025-03-07 12:31:07 UTC
Created attachment 179073 [details] [review]
Bug 39154: Add sip.log test in about

See bug 36954. The file sip.log should not be found anymore in
log4perl.conf.

Test plan:
Edit log4perl.conf. Replace sip-output.log by sip.log.
Check About, tab sysinfo. You should see a warn.
Edit again. Switch back to sip-output.log.
Verify that there is no warn anymore on about.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Katrin Fischer 2025-03-07 17:04:27 UTC
Pushed for 25.05!

Well done everyone, thank you!