Bug 39154 - About: add a warning for obsoleted sip.log
Summary: About: add a warning for obsoleted sip.log
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: About (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Marcel de Rooy
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 36954 39153
Blocks:
  Show dependency treegraph
 
Reported: 2025-02-18 13:22 UTC by Marcel de Rooy
Modified: 2025-03-07 17:04 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39154: Add sip.log test in about (2.20 KB, patch)
2025-02-18 14:37 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 39154: Add sip.log test in about (2.21 KB, patch)
2025-02-18 17:25 UTC, David Nind
Details | Diff | Splinter Review
Bug 39154: Add sip.log test in about (2.27 KB, patch)
2025-03-07 12:31 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2025-02-18 13:22:03 UTC
See 36954.
Comment 1 Marcel de Rooy 2025-02-18 14:37:08 UTC
Created attachment 178275 [details] [review]
Bug 39154: Add sip.log test in about

See bug 36954. The file sip.log should not be found anymore in
log4perl.conf.

Test plan:
Edit log4perl.conf. Replace sip-output.log by sip.log.
Check About, tab sysinfo. You should see a warn.
Edit again. Switch back to sip-output.log.
Verify that there is no warn anymore on about.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 David Nind 2025-02-18 17:25:42 UTC
Created attachment 178293 [details] [review]
Bug 39154: Add sip.log test in about

See bug 36954. The file sip.log should not be found anymore in
log4perl.conf.

Test plan:
Edit log4perl.conf. Replace sip-output.log by sip.log.
Check About, tab sysinfo. You should see a warn.
Edit again. Switch back to sip-output.log.
Verify that there is no warn anymore on about.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2025-02-19 12:06:58 UTC
(In reply to David Nind from comment #2)
> Signed-off-by: David Nind <david@davidnind.com>

Thanks David!
Comment 4 Martin Renvoize (ashimema) 2025-03-07 12:31:07 UTC
Created attachment 179073 [details] [review]
Bug 39154: Add sip.log test in about

See bug 36954. The file sip.log should not be found anymore in
log4perl.conf.

Test plan:
Edit log4perl.conf. Replace sip-output.log by sip.log.
Check About, tab sysinfo. You should see a warn.
Edit again. Switch back to sip-output.log.
Verify that there is no warn anymore on about.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Katrin Fischer 2025-03-07 17:04:27 UTC
Pushed for 25.05!

Well done everyone, thank you!