There is a check in tab about which should be moved to sysinfo..
Created attachment 178268 [details] [review] Bug 39153: Move log4perl checks in about.pl They were mostly under tab about, but they should be under sysinfo. Test plan: Move your log4perl file and verify that about complains on sysinfo. Note that you cannot simulate logfile_not_writable, since it crashes plack.psgi before reaching about.pl. See 39155. Bonus: Edit the moved if( !-w $file ) test and replace it by if ( 1 ). Restart and verify that you now have an error message on sysinfo. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 178269 [details] [review] Bug 39153: Move log4perl checks in about.pl They were mostly under tab about, but they should be under sysinfo. Test plan: If you would move your log4perl file, plack.psgi crashes. So sorry but we cannot test that. Note that you cannot simulate logfile_not_writable either, since it also crashes plack.psgi before reaching about.pl. See 39155. So a trivial hack remains: Bonus: Edit about.pl and changed the moved if( !-w $file ) test and replace it by if ( 1 ) in the new sub log4perl_check. Restart and verify that you now have an error message on sysinfo. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 178299 [details] [review] Bug 39153: Move log4perl checks in about.pl They were mostly under tab about, but they should be under sysinfo. Test plan: If you would move your log4perl file, plack.psgi crashes. So sorry but we cannot test that. Note that you cannot simulate logfile_not_writable either, since it also crashes plack.psgi before reaching about.pl. See 39155. So a trivial hack remains: Bonus: Edit about.pl and changed the moved if( !-w $file ) test and replace it by if ( 1 ) in the new sub log4perl_check. Restart and verify that you now have an error message on sysinfo. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 179071 [details] [review] Bug 39153: Move log4perl checks in about.pl They were mostly under tab about, but they should be under sysinfo. Test plan: If you would move your log4perl file, plack.psgi crashes. So sorry but we cannot test that. Note that you cannot simulate logfile_not_writable either, since it also crashes plack.psgi before reaching about.pl. See 39155. So a trivial hack remains: Bonus: Edit about.pl and changed the moved if( !-w $file ) test and replace it by if ( 1 ) in the new sub log4perl_check. Restart and verify that you now have an error message on sysinfo. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed for 25.05! Well done everyone, thank you!