Bug 39153 - About does not handle log4perl warnings correctly.
Summary: About does not handle log4perl warnings correctly.
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: About (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Marcel de Rooy
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks: 39154
  Show dependency treegraph
 
Reported: 2025-02-18 13:21 UTC by Marcel de Rooy
Modified: 2025-03-07 14:42 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39153: Move log4perl checks in about.pl (3.53 KB, patch)
2025-02-18 14:11 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 39153: Move log4perl checks in about.pl (3.64 KB, patch)
2025-02-18 14:15 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 39153: Move log4perl checks in about.pl (3.65 KB, patch)
2025-02-18 17:53 UTC, David Nind
Details | Diff | Splinter Review
Bug 39153: Move log4perl checks in about.pl (3.71 KB, patch)
2025-03-07 12:22 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2025-02-18 13:21:21 UTC
There is a check in tab about which should be moved to sysinfo..
Comment 1 Marcel de Rooy 2025-02-18 14:11:22 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2025-02-18 14:15:12 UTC
Created attachment 178269 [details] [review]
Bug 39153: Move log4perl checks in about.pl

They were mostly under tab about, but they should be under sysinfo.

Test plan:
If you would move your log4perl file, plack.psgi crashes. So sorry
but we cannot test that.
Note that you cannot simulate logfile_not_writable either, since it
also crashes plack.psgi before reaching about.pl. See 39155.

So a trivial hack remains:
Bonus: Edit about.pl and changed the moved if( !-w $file ) test and
replace it by if ( 1 ) in the new sub log4perl_check.
Restart and verify that you now have an error message on sysinfo.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 David Nind 2025-02-18 17:53:46 UTC
Created attachment 178299 [details] [review]
Bug 39153: Move log4perl checks in about.pl

They were mostly under tab about, but they should be under sysinfo.

Test plan:
If you would move your log4perl file, plack.psgi crashes. So sorry
but we cannot test that.
Note that you cannot simulate logfile_not_writable either, since it
also crashes plack.psgi before reaching about.pl. See 39155.

So a trivial hack remains:
Bonus: Edit about.pl and changed the moved if( !-w $file ) test and
replace it by if ( 1 ) in the new sub log4perl_check.
Restart and verify that you now have an error message on sysinfo.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Martin Renvoize (ashimema) 2025-03-07 12:22:22 UTC
Created attachment 179071 [details] [review]
Bug 39153: Move log4perl checks in about.pl

They were mostly under tab about, but they should be under sysinfo.

Test plan:
If you would move your log4perl file, plack.psgi crashes. So sorry
but we cannot test that.
Note that you cannot simulate logfile_not_writable either, since it
also crashes plack.psgi before reaching about.pl. See 39155.

So a trivial hack remains:
Bonus: Edit about.pl and changed the moved if( !-w $file ) test and
replace it by if ( 1 ) in the new sub log4perl_check.
Restart and verify that you now have an error message on sysinfo.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Katrin Fischer 2025-03-07 14:42:57 UTC
Pushed for 25.05!

Well done everyone, thank you!