Summary: | Merging records no longer compares side by side | ||
---|---|---|---|
Product: | Koha | Reporter: | Lisette Scheer <lisette> |
Component: | Architecture, internals, and plumbing | Assignee: | Lisette Scheer <lisette> |
Status: | Pushed to stable --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | bowens, martin.renvoize, mspinney, nmumford, paul.derscheid, phil, rkuiper |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This patch fixes a regression when merging records in the cataloging module. Columns will show side by side again when comparing records for a merge.
|
|
Version(s) released in: |
25.05.00,24.11.03
|
Circulation function: | |
Bug Depends on: | 35402 | ||
Bug Blocks: | |||
Attachments: |
Before Bootstrap comparison
Bug 39172: Merging records no longer compares side by side Bug 39172: Merging records no longer compares side by side Bug 39172: Merging records no longer compares side by side Bug 39172: Merging records no longer compares side by side Bug 39172: Merging records no longer compares side by side |
Description
Lisette Scheer
2025-02-19 18:07:43 UTC
Created attachment 178800 [details] [review] Bug 39172: Merging records no longer compares side by side This patch updates the cataloging merge screen to restore side-by-side comparison. Both columns had ids added by the patch for formatting purposes. To test: 1. Go to cataloging module 2. Do a search (in sandboxes/ktd 1 works) 3. Select 2 or more records to merge 4. Click the "merge selected" button 5. Observe there are 2 columns on top of each other instead of side by side 6. Apply the patch 7. Restart all & rebuild css 8. Repeat steps 1-4 9. Observe the columns are side by side again. 10. Sign-off Created attachment 178807 [details] [review] Bug 39172: Merging records no longer compares side by side This patch updates the cataloging merge screen to restore side-by-side comparison. Both columns had ids added by the patch for formatting purposes. To test: 1. Go to cataloging module 2. Do a search (in sandboxes/ktd 1 works) 3. Select 2 or more records to merge 4. Click the "merge selected" button 5. Observe there are 2 columns on top of each other instead of side by side 6. Apply the patch 7. Restart all & rebuild css 8. Repeat steps 1-4 9. Observe the columns are side by side again. 10. Sign-off Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 178809 [details] [review] Bug 39172: Merging records no longer compares side by side This patch updates the cataloging merge screen to restore side-by-side comparison. Both columns had ids added by the patch for formatting purposes. To test: 1. Go to cataloging module 2. Do a search (in sandboxes/ktd 1 works) 3. Select 2 or more records to merge 4. Click the "merge selected" button 5. Observe there are 2 columns on top of each other instead of side by side 6. Apply the patch 7. Restart all & rebuild css 8. Repeat steps 1-4 9. Observe the columns are side by side again. 10. Sign-off Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: jason vasche <jvasche@roundrocktexas.gov> Created attachment 178810 [details] [review] Bug 39172: Merging records no longer compares side by side This patch updates the cataloging merge screen to restore side-by-side comparison. Both columns had ids added by the patch for formatting purposes. To test: 1. Go to cataloging module 2. Do a search (in sandboxes/ktd 1 works) 3. Select 2 or more records to merge 4. Click the "merge selected" button 5. Observe there are 2 columns on top of each other instead of side by side 6. Apply the patch 7. Restart all & rebuild css 8. Repeat steps 1-4 9. Observe the columns are side by side again. 10. Sign-off Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: jason vasche <jvasche@roundrocktexas.gov> Created attachment 179098 [details] [review] Bug 39172: Merging records no longer compares side by side This patch updates the cataloging merge screen to restore side-by-side comparison. Both columns had ids added by the patch for formatting purposes. To test: 1. Go to cataloging module 2. Do a search (in sandboxes/ktd 1 works) 3. Select 2 or more records to merge 4. Click the "merge selected" button 5. Observe there are 2 columns on top of each other instead of side by side 6. Apply the patch 7. Restart all & rebuild css 8. Repeat steps 1-4 9. Observe the columns are side by side again. 10. Sign-off Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jason Vasche <jvasche@roundrocktexas.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Pushed for 25.05! Well done everyone, thank you! Can this be backported to 24.11 since this restores function we had previously. Thanks, Rhonda K. (In reply to Rhonda Kuiper from comment #7) > Can this be backported to 24.11 since this restores function we had > previously. > Thanks, > Rhonda K. Hi Rhonda, usually bug fixes will be backported if the bug exists in the lower versions as well - it can help RMaints to have confirmation about that. I'll also add the rel... keyword to highlight it. Nice work everyone! Pushed to 24.11.x for 24.11.03 This issue was also a problem for comparing files during vendor uploads. The original record used to be side by side with the imported record. Post upgrade the imported record was pushed to the bottom, under the original record. This is still not fixed and was reported to Bywater today 3/31. (In reply to Nancy M. from comment #10) > This issue was also a problem for comparing files during vendor uploads. The > original record used to be side by side with the imported record. Post > upgrade the imported record was pushed to the bottom, under the original > record. This is still not fixed and was reported to Bywater today 3/31. Hi Nancy, thanks for your comment. As this has already been pushed and backported to stable versions, we'll need a separate bug report to fix the vendor uploads. |