Bug 39172 - Merging records no longer compares side by side
Summary: Merging records no longer compares side by side
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lisette Scheer
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 35402
Blocks:
  Show dependency treegraph
 
Reported: 2025-02-19 18:07 UTC by Lisette Scheer
Modified: 2025-04-06 10:51 UTC (History)
7 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This patch fixes a regression when merging records in the cataloging module. Columns will show side by side again when comparing records for a merge.
Version(s) released in:
25.05.00,24.11.03
Circulation function:


Attachments
Before Bootstrap comparison (260.75 KB, image/png)
2025-02-19 18:07 UTC, Lisette Scheer
Details
Bug 39172: Merging records no longer compares side by side (2.47 KB, patch)
2025-02-27 16:57 UTC, Lisette Scheer
Details | Diff | Splinter Review
Bug 39172: Merging records no longer compares side by side (2.53 KB, patch)
2025-02-27 18:32 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39172: Merging records no longer compares side by side (2.58 KB, patch)
2025-02-27 21:15 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 39172: Merging records no longer compares side by side (2.58 KB, patch)
2025-02-27 21:16 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 39172: Merging records no longer compares side by side (2.65 KB, patch)
2025-03-10 12:01 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lisette Scheer 2025-02-19 18:07:43 UTC
Created attachment 178372 [details]
Before Bootstrap comparison

After Bug 35402 the record merge now longer shows the final record next to the selected records, but shows instead.
I checked out the commit before 35402 and then checked out 35402 to compare, then also confirmed on main.
Comment 1 Lisette Scheer 2025-02-27 16:57:12 UTC
Created attachment 178800 [details] [review]
Bug 39172: Merging records no longer compares side by side

This patch updates the cataloging merge screen to restore side-by-side comparison.

Both columns had ids added by the patch for formatting purposes.

To test:
1. Go to cataloging module
2. Do a search (in sandboxes/ktd 1 works)
3. Select 2 or more records to merge
4. Click the "merge selected" button
5. Observe there are 2 columns on top of each other instead of side by side
6. Apply the patch
7. Restart all & rebuild css
8. Repeat steps 1-4
9. Observe the columns are side by side again.
10. Sign-off
Comment 2 Owen Leonard 2025-02-27 18:32:55 UTC
Created attachment 178807 [details] [review]
Bug 39172: Merging records no longer compares side by side

This patch updates the cataloging merge screen to restore side-by-side
comparison.

Both columns had ids added by the patch for formatting purposes.

To test:
1. Go to cataloging module
2. Do a search (in sandboxes/ktd 1 works)
3. Select 2 or more records to merge
4. Click the "merge selected" button
5. Observe there are 2 columns on top of each other instead of side by
   side
6. Apply the patch
7. Restart all & rebuild css
8. Repeat steps 1-4
9. Observe the columns are side by side again.
10. Sign-off

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Biblibre Sandboxes 2025-02-27 21:15:43 UTC
Created attachment 178809 [details] [review]
Bug 39172: Merging records no longer compares side by side

This patch updates the cataloging merge screen to restore side-by-side
comparison.

Both columns had ids added by the patch for formatting purposes.

To test:
1. Go to cataloging module
2. Do a search (in sandboxes/ktd 1 works)
3. Select 2 or more records to merge
4. Click the "merge selected" button
5. Observe there are 2 columns on top of each other instead of side by
   side
6. Apply the patch
7. Restart all & rebuild css
8. Repeat steps 1-4
9. Observe the columns are side by side again.
10. Sign-off

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: jason vasche <jvasche@roundrocktexas.gov>
Comment 4 Biblibre Sandboxes 2025-02-27 21:16:03 UTC
Created attachment 178810 [details] [review]
Bug 39172: Merging records no longer compares side by side

This patch updates the cataloging merge screen to restore side-by-side
comparison.

Both columns had ids added by the patch for formatting purposes.

To test:
1. Go to cataloging module
2. Do a search (in sandboxes/ktd 1 works)
3. Select 2 or more records to merge
4. Click the "merge selected" button
5. Observe there are 2 columns on top of each other instead of side by
   side
6. Apply the patch
7. Restart all & rebuild css
8. Repeat steps 1-4
9. Observe the columns are side by side again.
10. Sign-off

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: jason vasche <jvasche@roundrocktexas.gov>
Comment 5 Martin Renvoize (ashimema) 2025-03-10 12:01:58 UTC
Created attachment 179098 [details] [review]
Bug 39172: Merging records no longer compares side by side

This patch updates the cataloging merge screen to restore side-by-side
comparison.

Both columns had ids added by the patch for formatting purposes.

To test:
1. Go to cataloging module
2. Do a search (in sandboxes/ktd 1 works)
3. Select 2 or more records to merge
4. Click the "merge selected" button
5. Observe there are 2 columns on top of each other instead of side by
   side
6. Apply the patch
7. Restart all & rebuild css
8. Repeat steps 1-4
9. Observe the columns are side by side again.
10. Sign-off

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jason Vasche <jvasche@roundrocktexas.gov>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Katrin Fischer 2025-03-13 09:30:13 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 7 Rhonda Kuiper 2025-03-14 13:41:28 UTC
Can this be backported to 24.11 since this restores function we had previously.
Thanks,
Rhonda K.
Comment 8 Katrin Fischer 2025-03-14 15:05:47 UTC
(In reply to Rhonda Kuiper from comment #7)
> Can this be backported to 24.11 since this restores function we had
> previously.
> Thanks,
> Rhonda K.

Hi Rhonda, usually bug fixes will be backported if the bug exists in the lower versions as well - it can help RMaints to have confirmation about that. I'll also add the rel... keyword to highlight it.
Comment 9 Paul Derscheid 2025-03-23 14:09:33 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.03
Comment 10 Nancy M. 2025-03-31 18:28:17 UTC
This issue was also a problem for comparing files during vendor uploads. The original record used to be side by side with the imported record. Post upgrade the imported record was pushed to the bottom, under the original record. This is still not fixed and was reported to Bywater today 3/31.
Comment 11 Katrin Fischer 2025-04-06 10:51:56 UTC
(In reply to Nancy M. from comment #10)
> This issue was also a problem for comparing files during vendor uploads. The
> original record used to be side by side with the imported record. Post
> upgrade the imported record was pushed to the bottom, under the original
> record. This is still not fixed and was reported to Bywater today 3/31.

Hi Nancy, thanks for your comment. As this has already been pushed and backported to stable versions, we'll need a separate bug report to fix the vendor uploads.