Summary: | Remove box around subfield tag in basic editor | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
Component: | Cataloging | Assignee: | Phil Ringnalda <phil> |
Status: | Pushed to main --- | QA Contact: | Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski> |
Severity: | normal | ||
Priority: | P5 - low | CC: | m.de.rooy, phil |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
25.05.00
|
|
Circulation function: | |||
Bug Depends on: | 35402 | ||
Bug Blocks: | 39321 | ||
Attachments: |
bib edit screen in main
Bug 39293: Remove box around subfield tag in basic editor Bug 39293: Remove box around subfield tag in basic editor Bug 39293: Remove box around subfield tag in basic editor Bug 39293: Remove box around subfield tag in basic editor |
Description
Andrew Fuerste-Henry
2025-03-10 17:04:33 UTC
If we were going to intentionally show the border in just one of the two editors, I would have picked adding it in the authority editor, where I use the ability to edit subfield letters all the time. For bib records, if you do that much editing of existing subfield codes you really ought to spend an hour learning to use the advanced editor, where you can just type them directly. But I doubt it was intentional, since the lack of border comes from an awkwardly placed border:0; in a style attribute in the template, where it looks more like a mistake than the attempt to obscure a feature that it actually is. Created attachment 179190 [details] [review] Bug 39293: Remove box around subfield tag in basic editor Prior to the Bootstrap 5 update, the feature of editing subfield codes in the basic editor was kept subtle by putting the code in an <input>, but removing the border around the input, so it required either knowing the feature exists or accidentally clicking on or around the single letter code and seeing it turn into an editable input. This patch removes the border again, because when people accidentally see the feature, they are sometimes not pleased to see it. Test plan: 1. Without the patch, open the cataloging basic editor and switch to the "1" tab with the 100 fields. 2. Note that the codes for the subfields are clearly in editable inputs. 3. Apply patch, reload the editor page. 4. Note that now the codes look like just plain text, until you actually click on or very near the letter, when they become visible as inputs by having the focus border. Sponsored-by: Chetco Community Public Library Comment on attachment 179190 [details] [review] Bug 39293: Remove box around subfield tag in basic editor Gee, thanks tidy, completely removing addbiblio.tt sounds like a great idea. Created attachment 179221 [details] [review] Bug 39293: Remove box around subfield tag in basic editor Prior to the Bootstrap 5 update, the feature of editing subfield codes in the basic editor was kept subtle by putting the code in an <input>, but removing the border around the input, so it required either knowing the feature exists or accidentally clicking on or around the single letter code and seeing it turn into an editable input. This patch removes the border again, because when people accidentally see the feature, they are sometimes not pleased to see it. Test plan: 1. Without the patch, open the cataloging basic editor and switch to the "1" tab with the 100 fields. 2. Note that the codes for the subfields are clearly in editable inputs. 3. Apply patch, reload the editor page. 4. Note that now the codes look like just plain text, until you actually click on or very near the letter, when they become visible as inputs by having the focus border. Sponsored-by: Chetco Community Public Library Created attachment 179231 [details] [review] Bug 39293: Remove box around subfield tag in basic editor Prior to the Bootstrap 5 update, the feature of editing subfield codes in the basic editor was kept subtle by putting the code in an <input>, but removing the border around the input, so it required either knowing the feature exists or accidentally clicking on or around the single letter code and seeing it turn into an editable input. This patch removes the border again, because when people accidentally see the feature, they are sometimes not pleased to see it. Test plan: 1. Without the patch, open the cataloging basic editor and switch to the "1" tab with the 100 fields. 2. Note that the codes for the subfields are clearly in editable inputs. 3. Apply patch, reload the editor page. 4. Note that now the codes look like just plain text, until you actually click on or very near the letter, when they become visible as inputs by having the focus border. Sponsored-by: Chetco Community Public Library Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Created attachment 179500 [details] [review] Bug 39293: Remove box around subfield tag in basic editor Prior to the Bootstrap 5 update, the feature of editing subfield codes in the basic editor was kept subtle by putting the code in an <input>, but removing the border around the input, so it required either knowing the feature exists or accidentally clicking on or around the single letter code and seeing it turn into an editable input. This patch removes the border again, because when people accidentally see the feature, they are sometimes not pleased to see it. Test plan: 1. Without the patch, open the cataloging basic editor and switch to the "1" tab with the 100 fields. 2. Note that the codes for the subfields are clearly in editable inputs. 3. Apply patch, reload the editor page. 4. Note that now the codes look like just plain text, until you actually click on or very near the letter, when they become visible as inputs by having the focus border. Sponsored-by: Chetco Community Public Library Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Pushed for 25.05! Well done everyone, thank you! |