Bug 39293 - Remove box around subfield tag in basic editor
Summary: Remove box around subfield tag in basic editor
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Phil Ringnalda
QA Contact: Baptiste Wojtkowski (bwoj)
URL:
Keywords:
Depends on: 35402
Blocks: 39321
  Show dependency treegraph
 
Reported: 2025-03-10 17:04 UTC by Andrew Fuerste-Henry
Modified: 2025-03-20 13:31 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
bib edit screen in main (126.17 KB, image/png)
2025-03-10 17:04 UTC, Andrew Fuerste-Henry
Details
Bug 39293: Remove box around subfield tag in basic editor (71.17 KB, patch)
2025-03-12 03:44 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 39293: Remove box around subfield tag in basic editor (2.53 KB, patch)
2025-03-12 17:10 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 39293: Remove box around subfield tag in basic editor (2.59 KB, patch)
2025-03-12 19:50 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 39293: Remove box around subfield tag in basic editor (2.65 KB, patch)
2025-03-20 10:36 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2025-03-10 17:04:33 UTC
Created attachment 179128 [details]
bib edit screen in main

In 24.11 and later, the bootstrap update seems to have put a box around subfield tags (see attached screenshot).

These values have been editable for a long time, but putting boxes around them makes it really clear that this is possible. But manual editing of those subfield tags is not really the expected way to use this editor and opens one up to numerous cataloging errors. For this sort of unguided cataloging, we expect one to use the advanced editor.

I suggest we make those boxes go away again to make this questionable feature less obvious.

If we leave the boxes, we really need to fix bug 29253, in which one can use this subfield updating to violate framework constraints.
Comment 1 Andrew Fuerste-Henry 2025-03-10 17:06:23 UTC
oops, put the wrong bug number in that comment. Bug 29253 is not relevant here, but bug 39292 is!
Comment 2 Phil Ringnalda 2025-03-12 02:34:17 UTC
If we were going to intentionally show the border in just one of the two editors, I would have picked adding it in the authority editor, where I use the ability to edit subfield letters all the time. For bib records, if you do that much editing of existing subfield codes you really ought to spend an hour learning to use the advanced editor, where you can just type them directly.

But I doubt it was intentional, since the lack of border comes from an awkwardly placed border:0; in a style attribute in the template, where it looks more like a mistake than the attempt to obscure a feature that it actually is.
Comment 3 Phil Ringnalda 2025-03-12 03:44:30 UTC
Created attachment 179190 [details] [review]
Bug 39293: Remove box around subfield tag in basic editor

Prior to the Bootstrap 5 update, the feature of editing subfield codes in the
basic editor was kept subtle by putting the code in an <input>, but removing
the border around the input, so it required either knowing the feature exists
or accidentally clicking on or around the single letter code and seeing it
turn into an editable input.

This patch removes the border again, because when people accidentally see the
feature, they are sometimes not pleased to see it.

Test plan:
1. Without the patch, open the cataloging basic editor and switch to the "1"
   tab with the 100 fields.
2. Note that the codes for the subfields are clearly in editable inputs.
3. Apply patch, reload the editor page.
4. Note that now the codes look like just plain text, until you actually
   click on or very near the letter, when they become visible as inputs
   by having the focus border.

Sponsored-by: Chetco Community Public Library
Comment 4 Phil Ringnalda 2025-03-12 03:46:04 UTC
Comment on attachment 179190 [details] [review]
Bug 39293: Remove box around subfield tag in basic editor

Gee, thanks tidy, completely removing addbiblio.tt sounds like a great idea.
Comment 5 Phil Ringnalda 2025-03-12 17:10:52 UTC
Created attachment 179221 [details] [review]
Bug 39293: Remove box around subfield tag in basic editor

Prior to the Bootstrap 5 update, the feature of editing subfield codes in the
basic editor was kept subtle by putting the code in an <input>, but removing
the border around the input, so it required either knowing the feature exists
or accidentally clicking on or around the single letter code and seeing it
turn into an editable input.

This patch removes the border again, because when people accidentally see the
feature, they are sometimes not pleased to see it.

Test plan:
1. Without the patch, open the cataloging basic editor and switch to the "1"
   tab with the 100 fields.
2. Note that the codes for the subfields are clearly in editable inputs.
3. Apply patch, reload the editor page.
4. Note that now the codes look like just plain text, until you actually
   click on or very near the letter, when they become visible as inputs
   by having the focus border.

Sponsored-by: Chetco Community Public Library
Comment 6 Andrew Fuerste-Henry 2025-03-12 19:50:18 UTC
Created attachment 179231 [details] [review]
Bug 39293: Remove box around subfield tag in basic editor

Prior to the Bootstrap 5 update, the feature of editing subfield codes in the
basic editor was kept subtle by putting the code in an <input>, but removing
the border around the input, so it required either knowing the feature exists
or accidentally clicking on or around the single letter code and seeing it
turn into an editable input.

This patch removes the border again, because when people accidentally see the
feature, they are sometimes not pleased to see it.

Test plan:
1. Without the patch, open the cataloging basic editor and switch to the "1"
   tab with the 100 fields.
2. Note that the codes for the subfields are clearly in editable inputs.
3. Apply patch, reload the editor page.
4. Note that now the codes look like just plain text, until you actually
   click on or very near the letter, when they become visible as inputs
   by having the focus border.

Sponsored-by: Chetco Community Public Library
Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Comment 7 Baptiste Wojtkowski (bwoj) 2025-03-20 10:36:40 UTC
Created attachment 179500 [details] [review]
Bug 39293: Remove box around subfield tag in basic editor

Prior to the Bootstrap 5 update, the feature of editing subfield codes in the
basic editor was kept subtle by putting the code in an <input>, but removing
the border around the input, so it required either knowing the feature exists
or accidentally clicking on or around the single letter code and seeing it
turn into an editable input.

This patch removes the border again, because when people accidentally see the
feature, they are sometimes not pleased to see it.

Test plan:
1. Without the patch, open the cataloging basic editor and switch to the "1"
   tab with the 100 fields.
2. Note that the codes for the subfields are clearly in editable inputs.
3. Apply patch, reload the editor page.
4. Note that now the codes look like just plain text, until you actually
   click on or very near the letter, when they become visible as inputs
   by having the focus border.

Sponsored-by: Chetco Community Public Library
Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
Comment 8 Katrin Fischer 2025-03-20 13:31:48 UTC
Pushed for 25.05!

Well done everyone, thank you!