I think Koha intends to hide the subfield tag entirely when one is viewing a control field? If you open up a bib or authority for editing in the basic editor, you'll see that the control fields show a subfield tag of "00." You'll also notice that the second zero is cut off. This was true before Bug 39293, but those boxes made me think about it more :) I started to patch it so that both zeros would show, but it really looks like the intent is to hide them instead: style=" [% IF ( subfield_loo.fixedfield ) %]display:none; [% END %]" https://github.com/Koha-Community/Koha/blob/10d781c7b98d4e90e131c478638f3dc4a589ecb0/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt#L1132 This maybe changed with bug 22399, back in 20.11? I sure didn't notice it at the time.
Actually, looks like we also intend to hide the subfield label for these, so we would not show "fixed length control field" or "control field." Looks like this check in addbiblio.tt isn't returning a value for some reason? fixedfield => $tag < 10 ? 1 : 0,
Created attachment 179248 [details] [review] Bug 39321: Hide subfield tag information for control fields in bib and authority editing This applies only to the basic editor, but for both bibs and authorities To test: 1 - Open a bib in the basic editor, see that the control fields show the subfield tag value label and that the value of 00 is slightly cut off in the display 2 - Open an authority in the basic editor and confirm same 3 - apply patch 4 - reload your records and see that the subfield value and label are now hidden for control fields in both bib and authrority editing
I think it's more likely that it never worked to hide the 00 - I'm looking at a screenshot in the 16.11 manual, and at that point the 00 was showing. For it to ever work, the script would have had to set fixedfield in @subfields_data rather than just in %tagdata, and I can't find that it ever did.
Created attachment 179293 [details] [review] Bug 39321: Hide subfield tag information for control fields in bib and authority editing This applies only to the basic editor, but for both bibs and authorities To test: 1 - Open a bib in the basic editor, see that the control fields show the subfield tag value label and that the value of 00 is slightly cut off in the display 2 - Open an authority in the basic editor and confirm same 3 - apply patch 4 - reload your records and see that the subfield value and label are now hidden for control fields in both bib and authrority editing Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
*** Bug 39476 has been marked as a duplicate of this bug. ***
Created attachment 181151 [details] [review] Bug 39321: Hide subfield tag information for control fields in bib and authority editing This applies only to the basic editor, but for both bibs and authorities To test: 1 - Open a bib in the basic editor, see that the control fields show the subfield tag value label and that the value of 00 is slightly cut off in the display 2 - Open an authority in the basic editor and confirm same 3 - apply patch 4 - reload your records and see that the subfield value and label are now hidden for control fields in both bib and authrority editing Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 25.05! Well done everyone, thank you!