Bug 39321 - Hide subfield tag for fixed length control fields
Summary: Hide subfield tag for fixed length control fields
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Andrew Fuerste-Henry
QA Contact: Marcel de Rooy
URL:
Keywords:
: 39476 (view as bug list)
Depends on: 39293
Blocks:
  Show dependency treegraph
 
Reported: 2025-03-13 12:41 UTC by Andrew Fuerste-Henry
Modified: 2025-04-22 06:50 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39321: Hide subfield tag information for control fields in bib and authority editing (5.61 KB, patch)
2025-03-13 13:35 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 39321: Hide subfield tag information for control fields in bib and authority editing (5.67 KB, patch)
2025-03-13 23:31 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 39321: Hide subfield tag information for control fields in bib and authority editing (5.76 KB, patch)
2025-04-18 07:43 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2025-03-13 12:41:01 UTC
I think Koha intends to hide the subfield tag entirely when one is viewing a control field?

If you open up a bib or authority for editing in the basic editor, you'll see that the control fields show a subfield tag of "00." You'll also notice that the second zero is cut off. This was true before Bug 39293, but those boxes made me think about it more :)

I started to patch it so that both zeros would show, but it really looks like the intent is to hide them instead:

style=" [% IF ( subfield_loo.fixedfield ) %]display:none; [% END %]"

https://github.com/Koha-Community/Koha/blob/10d781c7b98d4e90e131c478638f3dc4a589ecb0/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt#L1132

This maybe changed with bug 22399, back in 20.11? I sure didn't notice it at the time.
Comment 1 Andrew Fuerste-Henry 2025-03-13 13:23:13 UTC
Actually, looks like we also intend to hide the subfield label for these, so we would not show "fixed length control field" or "control field."

Looks like this check in addbiblio.tt isn't returning a value for some reason?  
fixedfield    => $tag < 10 ? 1 : 0,
Comment 2 Andrew Fuerste-Henry 2025-03-13 13:35:54 UTC
Created attachment 179248 [details] [review]
Bug 39321: Hide subfield tag information for control fields in bib and authority editing

This applies only to the basic editor, but for both bibs and authorities
To test:
1 - Open a bib in the basic editor, see that the control fields show the subfield tag value label and that the value of 00 is slightly cut off in the display
2 - Open an authority in the basic editor and confirm same
3 - apply patch
4 - reload your records and see that the subfield value and label are now hidden for control fields in both bib and authrority editing
Comment 3 Phil Ringnalda 2025-03-13 23:20:21 UTC
I think it's more likely that it never worked to hide the 00 - I'm looking at a screenshot in the 16.11 manual, and at that point the 00 was showing. For it to ever work, the script would have had to set fixedfield in @subfields_data rather than just in %tagdata, and I can't find that it ever did.
Comment 4 Phil Ringnalda 2025-03-13 23:31:28 UTC
Created attachment 179293 [details] [review]
Bug 39321: Hide subfield tag information for control fields in bib and authority editing

This applies only to the basic editor, but for both bibs and authorities
To test:
1 - Open a bib in the basic editor, see that the control fields show the subfield tag value label and that the value of 00 is slightly cut off in the display
2 - Open an authority in the basic editor and confirm same
3 - apply patch
4 - reload your records and see that the subfield value and label are now hidden for control fields in both bib and authrority editing

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 5 Phil Ringnalda 2025-03-28 01:18:13 UTC
*** Bug 39476 has been marked as a duplicate of this bug. ***
Comment 6 Marcel de Rooy 2025-04-18 07:43:14 UTC
Created attachment 181151 [details] [review]
Bug 39321: Hide subfield tag information for control fields in bib and authority editing

This applies only to the basic editor, but for both bibs and authorities
To test:
1 - Open a bib in the basic editor, see that the control fields show the subfield tag value label and that the value of 00 is slightly cut off in the display
2 - Open an authority in the basic editor and confirm same
3 - apply patch
4 - reload your records and see that the subfield value and label are now hidden for control fields in both bib and authrority editing

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Katrin Fischer 2025-04-22 06:50:25 UTC
Pushed for 25.05!

Well done everyone, thank you!