Bug 39543

Summary: Error modal when trying to add two controlling licences to an agreement duplicates error message
Product: Koha Reporter: Andrew Auld <andrew.auld>
Component: ERMAssignee: Andrew Auld <andrew.auld>
Status: Pushed to main --- QA Contact: Lisette Scheer <lisette>
Severity: trivial    
Priority: P5 - low CC: jonathan.druart, jonathan.field, lisette, martin.renvoize, matt.blenkinsop, pedro.amorim
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Attachments: Screenshot of error modal
Bug 39543: Remove duplicated code in agreements controlling licence error message Test plan 1) Enable ERMModule sys pref 2) Add an agreement record 3) Add two licence records 4) Edit the agreement record and associate both license records to the agreement
Bug 39543: Error modal when trying to add two controlling licences to an agreement duplicates error message
Bug 39543: Error modal when trying to add two controlling licences to an agreement duplicates error message

Description Andrew Auld 2025-04-03 10:28:36 UTC
Created attachment 180488 [details]
Screenshot of error modal

If you try to add two licences with the status 'controlling' to an agreement record, the error modal duplicates the error message 'Only one controlling license is allowed'.
Comment 1 Andrew Auld 2025-04-03 10:45:24 UTC Comment hidden (obsolete)
Comment 2 Andrew Auld 2025-04-03 10:47:21 UTC
Sorry for the duff formatting on the test plan:

Test Plan:
1) Enable ERMModule sys pref
2) Add an agreement record
3) Add two licence records
4) Edit the agreement record and associate both license records to the agreement
5) Try to set both licenses to status 'controlling'
6) Note error modal duplicates the error message 'Only one controlling license is allowed'
7) Apply the patch, run yarn js:build and then hard refresh the browser
8) Repeat steps 1 to 5 and enjoy the single error message!
Comment 3 Magnus Enger 2025-04-03 11:48:14 UTC
Created attachment 180491 [details] [review]
Bug 39543: Error modal when trying to add two controlling licences to an agreement duplicates error message

If you try to add two licences with the status 'controlling' to an
agreement record, the error modal duplicates the error message
'Only one controlling license is allowed'.

Test Plan:
1) Enable ERMModule sys pref
2) Add an agreement record
3) Add two licence records
4) Edit the agreement record and associate both license records to the agreement
5) Try to set both licenses to status 'controlling'
6) Note error modal duplicates the error message 'Only one controlling license is allowed'
7) Apply the patch, run yarn js:build and then hard refresh the browser
8) Repeat steps 1 to 5 and enjoy the single error message!

Signed-off-by: Magnus Enger <magnus@libriotech.no>
I took the liberty of fixing up the commit message a bit.
Comment 4 Lisette Scheer 2025-04-03 13:31:07 UTC
Created attachment 180526 [details] [review]
Bug 39543: Error modal when trying to add two controlling licences to an agreement duplicates error message

If you try to add two licences with the status 'controlling' to an
agreement record, the error modal duplicates the error message
'Only one controlling license is allowed'.

Test Plan:
1) Enable ERMModule sys pref
2) Add an agreement record
3) Add two licence records
4) Edit the agreement record and associate both license records to the agreement
5) Try to set both licenses to status 'controlling'
6) Note error modal duplicates the error message 'Only one controlling license is allowed'
7) Apply the patch, run yarn js:build and then hard refresh the browser
8) Repeat steps 1 to 5 and enjoy the single error message!

Signed-off-by: Magnus Enger <magnus@libriotech.no>
I took the liberty of fixing up the commit message a bit.
Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 5 Katrin Fischer 2025-04-11 07:56:37 UTC
Pushed for 25.05!

Well done everyone, thank you!