Bug 39586

Summary: 2 delete buttons when previewing a SQL report
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: ReportsAssignee: Lucas Gass (lukeg) <lucas>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: phil
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 39586: Remove duplicate delete button
Bug 39586: Remove duplicate delete button

Description Lucas Gass (lukeg) 2025-04-08 20:04:48 UTC
To recreate:

1. Create any report
2. From the list of reports click the dropdown next to 'Run'
3. Choose 'Preview SQL'
4. Notice 2 delete buttons.
Comment 1 Lucas Gass (lukeg) 2025-04-08 20:09:23 UTC
Created attachment 180731 [details] [review]
Bug 39586: Remove duplicate delete button

To test:

1. Create any report
2. From the list of reports click the dropdown next to 'Run'
3. Choose 'Preview SQL'
4. Notice 2 delete buttons.
5. APPLY PATCH
6. Try again, there should only be one delete button.
7. Confirm that button works and the report is deleted.
Comment 2 Roman Dolny 2025-04-08 21:14:52 UTC
Created attachment 180734 [details] [review]
Bug 39586: Remove duplicate delete button

To test:

1. Create any report
2. From the list of reports click the dropdown next to 'Run'
3. Choose 'Preview SQL'
4. Notice 2 delete buttons.
5. APPLY PATCH
6. Try again, there should only be one delete button.
7. Confirm that button works and the report is deleted.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 3 Phil Ringnalda 2025-04-08 23:43:46 UTC
The good news is that your patch looks very similar to the one that's already PQA, except that it absorbed the id attribute from the other one.

*** This bug has been marked as a duplicate of bug 39258 ***