Bug 39586 - 2 delete buttons when previewing a SQL report
Summary: 2 delete buttons when previewing a SQL report
Status: RESOLVED DUPLICATE of bug 39258
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-04-08 20:04 UTC by Lucas Gass (lukeg)
Modified: 2025-04-08 23:43 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 39586: Remove duplicate delete button (2.97 KB, patch)
2025-04-08 20:09 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 39586: Remove duplicate delete button (3.02 KB, patch)
2025-04-08 21:14 UTC, Roman Dolny
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2025-04-08 20:04:48 UTC
To recreate:

1. Create any report
2. From the list of reports click the dropdown next to 'Run'
3. Choose 'Preview SQL'
4. Notice 2 delete buttons.
Comment 1 Lucas Gass (lukeg) 2025-04-08 20:09:23 UTC
Created attachment 180731 [details] [review]
Bug 39586: Remove duplicate delete button

To test:

1. Create any report
2. From the list of reports click the dropdown next to 'Run'
3. Choose 'Preview SQL'
4. Notice 2 delete buttons.
5. APPLY PATCH
6. Try again, there should only be one delete button.
7. Confirm that button works and the report is deleted.
Comment 2 Roman Dolny 2025-04-08 21:14:52 UTC
Created attachment 180734 [details] [review]
Bug 39586: Remove duplicate delete button

To test:

1. Create any report
2. From the list of reports click the dropdown next to 'Run'
3. Choose 'Preview SQL'
4. Notice 2 delete buttons.
5. APPLY PATCH
6. Try again, there should only be one delete button.
7. Confirm that button works and the report is deleted.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 3 Phil Ringnalda 2025-04-08 23:43:46 UTC
The good news is that your patch looks very similar to the one that's already PQA, except that it absorbed the id attribute from the other one.

*** This bug has been marked as a duplicate of bug 39258 ***