In reports, if you go to Saved Reports and then select Preview SQL for one of your saved reports, you'll get a modal showing your SQL. That modal contains 2 delete buttons. It looks like the second one was added in error in Bug 35402.
Created attachment 179003 [details] [review] Bug 39258: Delete extra delete button in report preview To test: 1 - save a report 2 - click Preview SQL for that report from the Saved Reports page 3 - see there are two delete buttons 4 - apply patch, reload page 5 - now there is one delete button 6 - confirm that delete button gives a confirmation message and then deletes the report
It is perhaps worth noting that the button I remove with this patch doesn't work to begin with :)
Created attachment 179006 [details] [review] Bug 39258: Delete extra delete button in report preview To test: 1 - save a report 2 - click Preview SQL for that report from the Saved Reports page 3 - see there are two delete buttons 4 - apply patch, reload page 5 - now there is one delete button 6 - confirm that delete button gives a confirmation message and then deletes the report Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Created attachment 179499 [details] [review] Bug 39258: Delete extra delete button in report preview To test: 1 - save a report 2 - click Preview SQL for that report from the Saved Reports page 3 - see there are two delete buttons 4 - apply patch, reload page 5 - now there is one delete button 6 - confirm that delete button gives a confirmation message and then deletes the report Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
I think you removed the wrong one, the remaining one is not translatable? :) <a class="btn btn-default submit-form-link" href="#" data-id="' + reportid + '" data-action="guided_reports.pl" data-method="post" data-op="cud-delete" data-confirmation-msg="' + _("Are you sure you want to delete this report?") + '"><i class="fa fa-trash-can" aria-hidden="true"></i> Delete</a>\ - <a id="preview-modal-delete"href="#" class="btn btn-default" title="Delete this saved report"><i class="fa fa-trash-can aria-hidden="true""></i> ' + _("Delete") + '</a>\
Oh sorry for missing that one :O
Created attachment 179565 [details] [review] Bug 39258: Remove extra nonfunctional Delete button from report preview modal To test: 1 - save a report 2 - click Preview SQL for that report from the Saved Reports page 3 - see there are two delete buttons 4 - apply patch, reload page 5 - now there is one delete button 6 - confirm that delete button gives a confirmation message and then deletes the report 7 - Install a second language for the intranet 8 - switch to that language and confirm you have just 1 delete button, it is translated, and it works
Created attachment 179901 [details] [review] Bug 39258: Remove extra nonfunctional Delete button from report preview modal To test: 1 - save a report 2 - click Preview SQL for that report from the Saved Reports page 3 - see there are two delete buttons 4 - apply patch, reload page 5 - now there is one delete button 6 - confirm that delete button gives a confirmation message and then deletes the report 7 - Install a second language for the intranet 8 - switch to that language and confirm you have just 1 delete button, it is translated, and it works Signed-off-by: David Nind <david@davidnind.com>
Created attachment 180530 [details] [review] Bug 39258: Remove extra nonfunctional Delete button from report preview modal To test: 1 - save a report 2 - click Preview SQL for that report from the Saved Reports page 3 - see there are two delete buttons 4 - apply patch, reload page 5 - now there is one delete button 6 - confirm that delete button gives a confirmation message and then deletes the report 7 - Install a second language for the intranet 8 - switch to that language and confirm you have just 1 delete button, it is translated, and it works Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Looks good, thanks Andrew!
*** Bug 39586 has been marked as a duplicate of this bug. ***
Pushed for 25.05! Well done everyone, thank you!