Bug 39597

Summary: When cancelling multiple holds on a bib record cancel_hold_alert has very low contrast
Product: Koha Reporter: Brendan Lawlor <blawlor>
Component: AccessibilityAssignee: Brendan Lawlor <blawlor>
Status: Pushed to main --- QA Contact: Lucas Gass (lukeg) <lucas>
Severity: minor    
Priority: P5 - low CC: lucas, martin.renvoize, matt.blenkinsop, oleonard, phil
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Bug Depends on: 39274    
Bug Blocks:    
Attachments: screnshot
Bug 39597: Fix cancel_hold_alert badge color contrast for accesibilty
contrast with patch
Bug 39597: Fix cancel_hold_alert badge color contrast for accesibilty
screenshot with patch
Bug 39597: Fix cancel_hold_alert badge color contrast for accesibilty
Bug 39597: Fix cancel_hold_alert badge color contrast for accesibilty

Description Brendan Lawlor 2025-04-09 20:32:49 UTC
Created attachment 180747 [details]
screnshot

To recreate:
- Go to a bib record and place multiple holds on it
- Select multiple holds and click 'Cancel selected (4)'
- The Alert says 'This action will cancel 4 hold(s).'
- Note that the contrast on the number of holds is very low
Comment 1 Brendan Lawlor 2025-04-09 20:41:01 UTC
Created attachment 180748 [details] [review]
Bug 39597: Fix cancel_hold_alert badge color contrast for accesibilty

This patch updates the classes on the badge element to fix color contrast

To test:
1. Go to a bib record and place multiple holds on it
2. Select multiple holds and click 'Cancel selected (4)'
3. The Alert says 'This action will cancel 4 hold(s).'
4. Note that the contrast on the number of holds is very low
5. Click 'Cancel' apply patch and restart_all
6. Repeat steps 2-3
7. Note that the contrast on the number of holds is good
Comment 2 Brendan Lawlor 2025-04-09 20:43:36 UTC
Created attachment 180749 [details]
contrast with patch
Comment 3 Owen Leonard 2025-04-10 12:17:44 UTC
I think this is correct, but for the full fix it needs to be on top of Bug 39274, but drop the 'text-dark' part:

<span class='badge bg-danger'>
Comment 4 Brendan Lawlor 2025-04-10 13:30:17 UTC
Created attachment 180776 [details] [review]
Bug 39597: Fix cancel_hold_alert badge color contrast for accesibilty

This patch add a class for the background on the badge element to fix color contrast

To test:
1. Go to a bib record and place multiple holds on it
2. Select multiple holds and click 'Cancel selected (4)'
3. The Alert says 'This action will cancel 4 hold(s).'
4. Note that the contrast on the number of holds is very low
5. Click 'Cancel' apply patch and restart_all
6. Repeat steps 2-3
7. Note that the contrast on the number of holds is good
Comment 5 Brendan Lawlor 2025-04-10 13:34:09 UTC
Created attachment 180777 [details]
screenshot with patch

Thanks Owen!

With bug 39274 applied this looks good
Comment 6 Phil Ringnalda 2025-04-11 17:44:38 UTC
Created attachment 180885 [details] [review]
Bug 39597: Fix cancel_hold_alert badge color contrast for accesibilty

This patch add a class for the background on the badge element to fix color contrast

To test:
1. Go to a bib record and place multiple holds on it
2. Select multiple holds and click 'Cancel selected (4)'
3. The Alert says 'This action will cancel 4 hold(s).'
4. Note that the contrast on the number of holds is very low
5. Click 'Cancel' apply patch and restart_all
6. Repeat steps 2-3
7. Note that the contrast on the number of holds is good

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 7 Lucas Gass (lukeg) 2025-04-29 15:22:00 UTC
Created attachment 181670 [details] [review]
Bug 39597: Fix cancel_hold_alert badge color contrast for accesibilty

This patch add a class for the background on the badge element to fix color contrast

To test:
1. Go to a bib record and place multiple holds on it
2. Select multiple holds and click 'Cancel selected (4)'
3. The Alert says 'This action will cancel 4 hold(s).'
4. Note that the contrast on the number of holds is very low
5. Click 'Cancel' apply patch and restart_all
6. Repeat steps 2-3
7. Note that the contrast on the number of holds is good

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 8 Katrin Fischer 2025-05-02 06:55:13 UTC
Pushed for 25.05!

Well done everyone, thank you!