Summary: | Remove GetSuggestion from C4/Suggestions.pm | ||
---|---|---|---|
Product: | Koha | Reporter: | Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski> |
Component: | Architecture, internals, and plumbing | Assignee: | Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski> |
Status: | Needs Signoff --- | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 39722 | ||
Attachments: |
Bug 39721: Remove GetSuggestion from C4/Suggestions.pm
Bug 39721: Remove GetSuggestion from C4/Suggestions.pm Bug 39721: Remove GetSuggestion from C4/Suggestions.pm Bug 39721: Remove GetSuggestion from C4/Suggestions.pm Bug 39721: Changes suggestion_ref in order to remove it Bug 39721: (follow-up) Remove unblessed Bug 39721: tidy |
Description
Baptiste Wojtkowski (bwoj)
2025-04-24 08:49:24 UTC
Created attachment 181402 [details] [review] Bug 39721: Remove GetSuggestion from C4/Suggestions.pm This set of patches removes the major part of C4/Suggestions. They have been split for sake of QA's readability but should be squashed. Things to test: Create suggestion Update status of suggestion Create, see and receive an order containing a suggestion Create a suggestion on an already existing record (it will need validation) test cronjobs purge_suggestion and notice_unprocessed_suggestions Created attachment 181416 [details] [review] Bug 39721: Remove GetSuggestion from C4/Suggestions.pm 1 - Create suggestion 2 - Display a suggestion 3 - Amend a suggestion To do with and without patch Created attachment 182810 [details] [review] Bug 39721: Remove GetSuggestion from C4/Suggestions.pm 1 - Create suggestion 2 - Display a suggestion 3 - Amend a suggestion To do with and without patch I would not call unblessed but manipulate the object directly here. It's a bit more work here but it will be easier for the other changes. ping? Created attachment 185280 [details] [review] Bug 39721: Remove GetSuggestion from C4/Suggestions.pm 1 - Create suggestion 2 - Display a suggestion 3 - Amend a suggestion To do with and without patch Created attachment 185281 [details] [review] Bug 39721: Changes suggestion_ref in order to remove it suggestion_ref is quite messy, it needs to be reworked in order to use objects in suggestion.pl. As far as I studied, it is used as - the whole input from forms, - the default content to input in a form - the content that will be amended in order to propose another hash to modSuggestion. However, ModSuggestion will be removed so we don't need such a hash - every suggestion that need to be updated using the "change selected suggestion" tool - create the object suggestion_only, whose purpose is still unclear to me. As a result it is created by : > 25 my $suggestion_ref = { $input->Vars }; And by removing a number of keys depending on the use of suggestion_ref in the script. In this patch, we remove every code made to use suggestion_ref as the source object for form and use another variable, $stored_suggestion which is an object. In next patch we aim at fully removing $suggestion_ref, which is still used by ModSuggestion Created attachment 185282 [details] [review] Bug 39721: (follow-up) Remove unblessed Created attachment 185283 [details] [review] Bug 39721: tidy |