Bug 39722

Summary: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm
Product: Koha Reporter: Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski>
Component: Architecture, internals, and plumbingAssignee: Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski>
Status: Pushed to main --- QA Contact: Jonathan Druart <jonathan.druart>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart, matt.blenkinsop
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
26.05.00
Circulation function:
Bug Depends on: 39721    
Bug Blocks: 39723    
Attachments: Bug 39722: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm
Bug 39722: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm
Bug 39722: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm
Bug 39722: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm
Bug 39722: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm
Bug 39722: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm
Bug 39722: (follow-up) Remove find
Bug 39722: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm
Bug 39722: (follow-up) Remove find

Description Baptiste Wojtkowski (bwoj) 2025-04-24 08:52:33 UTC
See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990
Comment 1 Baptiste Wojtkowski (bwoj) 2025-04-24 08:53:28 UTC
Created attachment 181403 [details] [review]
Bug 39722: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm
Comment 2 Baptiste Wojtkowski (bwoj) 2025-04-24 09:33:46 UTC
Created attachment 181418 [details] [review]
Bug 39722: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm

Modify a suggestion through the editor
Note: This is done for ModSuggestion, which will also be remobed
Comment 3 Jonathan Druart 2025-05-27 08:49:16 UTC
Apply? [(y)es, (n)o, (i)nteractive] Applying: Bug 39722: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm
error: sha1 information is lacking or useless (C4/Acquisition.pm).
Comment 4 Baptiste Wojtkowski (bwoj) 2025-10-30 13:58:43 UTC
Created attachment 188656 [details] [review]
Bug 39722: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm
Comment 5 Baptiste Wojtkowski (bwoj) 2026-01-06 15:46:40 UTC
Created attachment 190942 [details] [review]
Bug 39722: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm
Comment 6 Matt Blenkinsop 2026-01-23 11:46:18 UTC
sha1 error when applying
Comment 7 Baptiste Wojtkowski (bwoj) 2026-01-23 12:36:03 UTC
Created attachment 191925 [details] [review]
Bug 39722: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm
Comment 8 Matt Blenkinsop 2026-01-23 13:44:24 UTC
Created attachment 191935 [details] [review]
Bug 39722: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk>
Comment 9 Jonathan Druart 2026-01-26 12:19:17 UTC
+    my $suggestion = Koha::Suggestions->find( { biblionumber => $biblionumber } );

biblionumber is not a primary or unique key, you cannot use find here.
Comment 10 Baptiste Wojtkowski (bwoj) 2026-01-29 15:33:21 UTC
Created attachment 192149 [details] [review]
Bug 39722: (follow-up) Remove find
Comment 11 Jonathan Druart 2026-01-30 14:10:01 UTC
Created attachment 192236 [details] [review]
Bug 39722: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 12 Jonathan Druart 2026-01-30 14:10:02 UTC
Created attachment 192237 [details] [review]
Bug 39722: (follow-up) Remove find

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 13 Lucas Gass (lukeg) 2026-02-06 22:20:13 UTC
Nice work everyone!

Pushed to main for 26.05