Bug 39726

Summary: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm
Product: Koha Reporter: Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski>
Component: Architecture, internals, and plumbingAssignee: Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski>
Status: Patch doesn't apply --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: roman.dolny
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 39725    
Bug Blocks: 39727    
Attachments: Bug 39726: Remove op connectDuplicate from acqui/newordersuggestions.pl
Bug 39726: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm
Bug 39726: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm

Description Baptiste Wojtkowski (bwoj) 2025-04-24 09:00:13 UTC
See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990
Comment 1 Baptiste Wojtkowski (bwoj) 2025-04-24 09:03:40 UTC
Created attachment 181407 [details] [review]
Bug 39726: Remove op connectDuplicate from acqui/newordersuggestions.pl

15:27:09> git grep connectDuplicate
acqui/newordersuggestion.pl:    * connectDuplicate :
acqui/newordersuggestion.pl:if ( $op eq 'connectDuplicate' ) {

connectDuplicate is never called from any template code is hence removed
Comment 2 Baptiste Wojtkowski (bwoj) 2025-04-24 09:03:42 UTC
Created attachment 181408 [details] [review]
Bug 39726: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm
Comment 3 Baptiste Wojtkowski (bwoj) 2025-04-24 09:45:14 UTC
Created attachment 181421 [details] [review]
Bug 39726: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm

To test:
Create a suggestion whose isbn fits an existing one (note: you must have
        a working search engine)
Comment 4 Roman Dolny 2025-05-18 12:47:29 UTC
kohadev-koha@kohadevbox:koha(bug_39726)$ git bz apply 39726

Bug 39726 - Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm

181407 - Bug 39726: Remove op connectDuplicate from acqui/newordersuggestions.pl
181421 - Bug 39726: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 39726: Remove op connectDuplicate from acqui/newordersuggestions.pl
Applying: Bug 39726: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm
error: sha1 information is lacking or useless (C4/Suggestions.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 39726: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm