Bug 39732

Summary: Remove MarcRecordFromNewSuggestion from C4/Suggestions.pm
Product: Koha Reporter: Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski>
Component: Architecture, internals, and plumbingAssignee: Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski>
Status: Needs Signoff --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 39730    
Bug Blocks: 23990    
Attachments: Bug 39732: Remove MarcRecordFromNewSuggestion from C4/Suggestions.pm
Bug 39732: Remove MarcRecordFromNewSuggestion from C4/Suggestions.pm

Description Baptiste Wojtkowski (bwoj) 2025-04-24 09:17:29 UTC
See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990
Comment 1 Baptiste Wojtkowski (bwoj) 2025-04-24 09:18:10 UTC
Created attachment 181412 [details] [review]
Bug 39732: Remove MarcRecordFromNewSuggestion from C4/Suggestions.pm
Comment 2 Baptiste Wojtkowski (bwoj) 2025-04-24 09:57:21 UTC
Created attachment 181425 [details] [review]
Bug 39732: Remove MarcRecordFromNewSuggestion from C4/Suggestions.pm

Note:
This function was necessary for a very weird purpose.
The whole process was:
1 - Have a suggestion as an hashref
2 - Convert it into a record
3 - Pass it to FindDuplicate
4 - C4/search exctract the exact same hashref as in 1 and performs the
  search

Hence we extracted from FindDuplicate the part that uses the hashref and
called it directly