Bug 39732 - Remove MarcRecordFromNewSuggestion from C4/Suggestions.pm
Summary: Remove MarcRecordFromNewSuggestion from C4/Suggestions.pm
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Baptiste Wojtkowski (bwoj)
QA Contact: Testopia
URL:
Keywords:
Depends on: 39730
Blocks: 23990
  Show dependency treegraph
 
Reported: 2025-04-24 09:17 UTC by Baptiste Wojtkowski (bwoj)
Modified: 2025-04-24 09:57 UTC (History)
0 users

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 39732: Remove MarcRecordFromNewSuggestion from C4/Suggestions.pm (11.12 KB, patch)
2025-04-24 09:18 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 39732: Remove MarcRecordFromNewSuggestion from C4/Suggestions.pm (11.46 KB, patch)
2025-04-24 09:57 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Baptiste Wojtkowski (bwoj) 2025-04-24 09:17:29 UTC
See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990
Comment 1 Baptiste Wojtkowski (bwoj) 2025-04-24 09:18:10 UTC
Created attachment 181412 [details] [review]
Bug 39732: Remove MarcRecordFromNewSuggestion from C4/Suggestions.pm
Comment 2 Baptiste Wojtkowski (bwoj) 2025-04-24 09:57:21 UTC
Created attachment 181425 [details] [review]
Bug 39732: Remove MarcRecordFromNewSuggestion from C4/Suggestions.pm

Note:
This function was necessary for a very weird purpose.
The whole process was:
1 - Have a suggestion as an hashref
2 - Convert it into a record
3 - Pass it to FindDuplicate
4 - C4/search exctract the exact same hashref as in 1 and performs the
  search

Hence we extracted from FindDuplicate the part that uses the hashref and
called it directly