Summary: | OAI expanded_avs option broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | OPAC | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | Pushed to main --- | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | major | ||
Priority: | P5 - low | CC: | angela.berrett |
Version: | Main | Keywords: | rel_24_11_candidate |
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.05.00
|
Circulation function: | |
Bug Depends on: | 31224 | ||
Bug Blocks: | |||
Attachments: |
Bug 39857: Fix expanded_avs option for OAI
Bug 39857: Fix expanded_avs option for OAI Bug 39857: Regression tests Bug 39857: Fix expanded_avs option for OAI |
Description
Nick Clemens (kidclamp)
2025-05-07 17:57:10 UTC
Created attachment 182037 [details] [review] Bug 39857: Fix expanded_avs option for OAI This patch correct the call to filter the record To test: 1 - Enable OAI 2 - Set OAI-PMH:ConfFile to '/var/lib/koha/kohadev/OAI.yaml' 3 - Edit/create the file above to have content: format: marcxml: metadataPrefix: marcxml metadataNamespace: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim schema: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd include_items: 1 expanded_avs: 1 4 - save and restart_all 5 - View some records: http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml 6 - Note the items show coded values 7 - Apply patch 8 - Restart all 9 - Refresh and confirm items now have descriptions Created attachment 182045 [details] [review] Bug 39857: Fix expanded_avs option for OAI This patch correct the call to filter the record To test: 1 - Enable OAI 2 - Set OAI-PMH:ConfFile to '/var/lib/koha/kohadev/OAI.yaml' 3 - Edit/create the file above to have content: format: marcxml: metadataPrefix: marcxml metadataNamespace: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim schema: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd include_items: 1 expanded_avs: 1 4 - save and restart_all 5 - View some records: http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml 6 - Note the items show coded values 7 - Apply patch 8 - Restart all 9 - Refresh and confirm items now have descriptions Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 182083 [details] [review] Bug 39857: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 182084 [details] [review] Bug 39857: Fix expanded_avs option for OAI This patch correct the call to filter the record To test: 1 - Enable OAI 2 - Set OAI-PMH:ConfFile to '/var/lib/koha/kohadev/OAI.yaml' 3 - Edit/create the file above to have content: format: marcxml: metadataPrefix: marcxml metadataNamespace: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim schema: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd include_items: 1 expanded_avs: 1 4 - save and restart_all 5 - View some records: http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml 6 - Note the items show coded values 7 - Apply the regressions tests patch 8 - Run: $ ktd --shell k$ prove t/db_dependent/Koha/OAI/Server/Repository.t => FAIL: Tests fail! 9 - Apply this patch 10 - Restart all 11 - Refresh and confirm items now have descriptions 12 - Repeat 8 => SUCCESS: Tests pass! Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Edit (tcohen): Amended the test plan to include the added regression tests run Pushed for 25.05! Well done everyone, thank you! (In reply to Katrin Fischer from comment #5) > Pushed for 25.05! > > Well done everyone, thank you! Any chance this can be backported to 24.11.xx? It's messing with a few other systems that talk to Koha for us. |