Bug 31224 moved OAI to use metadata_record - when doing so the param to expand fields was incorrectly added as: expand_coded_values => $expanded_avs, It should be: expand_coded_fields => $expanded_avs,
Created attachment 182037 [details] [review] Bug 39857: Fix expanded_avs option for OAI This patch correct the call to filter the record To test: 1 - Enable OAI 2 - Set OAI-PMH:ConfFile to '/var/lib/koha/kohadev/OAI.yaml' 3 - Edit/create the file above to have content: format: marcxml: metadataPrefix: marcxml metadataNamespace: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim schema: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd include_items: 1 expanded_avs: 1 4 - save and restart_all 5 - View some records: http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml 6 - Note the items show coded values 7 - Apply patch 8 - Restart all 9 - Refresh and confirm items now have descriptions
Created attachment 182045 [details] [review] Bug 39857: Fix expanded_avs option for OAI This patch correct the call to filter the record To test: 1 - Enable OAI 2 - Set OAI-PMH:ConfFile to '/var/lib/koha/kohadev/OAI.yaml' 3 - Edit/create the file above to have content: format: marcxml: metadataPrefix: marcxml metadataNamespace: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim schema: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd include_items: 1 expanded_avs: 1 4 - save and restart_all 5 - View some records: http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml 6 - Note the items show coded values 7 - Apply patch 8 - Restart all 9 - Refresh and confirm items now have descriptions Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 182083 [details] [review] Bug 39857: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 182084 [details] [review] Bug 39857: Fix expanded_avs option for OAI This patch correct the call to filter the record To test: 1 - Enable OAI 2 - Set OAI-PMH:ConfFile to '/var/lib/koha/kohadev/OAI.yaml' 3 - Edit/create the file above to have content: format: marcxml: metadataPrefix: marcxml metadataNamespace: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim schema: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd include_items: 1 expanded_avs: 1 4 - save and restart_all 5 - View some records: http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml 6 - Note the items show coded values 7 - Apply the regressions tests patch 8 - Run: $ ktd --shell k$ prove t/db_dependent/Koha/OAI/Server/Repository.t => FAIL: Tests fail! 9 - Apply this patch 10 - Restart all 11 - Refresh and confirm items now have descriptions 12 - Repeat 8 => SUCCESS: Tests pass! Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Edit (tcohen): Amended the test plan to include the added regression tests run
Pushed for 25.05! Well done everyone, thank you!
(In reply to Katrin Fischer from comment #5) > Pushed for 25.05! > > Well done everyone, thank you! Any chance this can be backported to 24.11.xx? It's messing with a few other systems that talk to Koha for us.