Summary: | Column filters are offset in ERM | ||
---|---|---|---|
Product: | Koha | Reporter: | Roman Dolny <roman.dolny> |
Component: | ERM | Assignee: | Matt Blenkinsop <matt.blenkinsop> |
Status: | Pushed to main --- | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | minor | ||
Priority: | P5 - low | CC: | jonathan.druart, jonathan.field, katrin.fischer, lucas, martin.renvoize, matt.blenkinsop, pedro.amorim |
Version: | unspecified | Keywords: | release-notes-needed |
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.11.00
|
Circulation function: | |
Bug Depends on: | 37273 | ||
Bug Blocks: | |||
Attachments: |
Bug 39951: Fix column filter offsets
Bug 39951: Fix column filter offsets Bug 39951: Fix column filter offsets Bug 39951: Fix column filter offsets |
Description
Roman Dolny
2025-05-20 22:06:17 UTC
Created attachment 182686 [details] [review] Bug 39951: Fix column filter offsets Test plan: 1) Enable ERM module 2) Create an agreement and a license with a vendor 3) The table filters will be out of sync - Agreements - only the vendor filter is incorrect, it sits above the name column instead of the vendor column - Licenses - all dropdown filter options will be left shifted by one 4) Apply patch 5) yarn js:build 6) Hard refresh the browser 7) All the filters should now be above the correct columns *** Bug 39950 has been marked as a duplicate of this bug. *** Thanks for patch, unfortunetely it doesn't apply. kohadev-koha@kohadevbox:koha(bug_39951)$ git bz apply 39951 Bug 39951 - No filter for Name column in licenses table in ERM 182686 - Bug 39951: Fix column filter offsets Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 39951: Fix column filter offsets Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue M koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue Auto-merging koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue error: Failed to merge in the changes. Patch failed at 0001 Bug 39951: Fix column filter offsets Created attachment 182720 [details] [review] Bug 39951: Fix column filter offsets Test plan: 1) Enable ERM module 2) Create an agreement and a license with a vendor 3) The table filters will be out of sync - Agreements - only the vendor filter is incorrect, it sits above the name column instead of the vendor column - Licenses - all dropdown filter options will be left shifted by one 4) Apply patch 5) yarn js:build 6) Hard refresh the browser 7) All the filters should now be above the correct columns Created attachment 182721 [details] [review] Bug 39951: Fix column filter offsets Test plan: 1) Enable ERM module 2) Create an agreement and a license with a vendor 3) The table filters will be out of sync - Agreements - only the vendor filter is incorrect, it sits above the name column instead of the vendor column - Licenses - all dropdown filter options will be left shifted by one 4) Apply patch 5) yarn js:build 6) Hard refresh the browser 7) All the filters should now be above the correct columns Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> *** Bug 40190 has been marked as a duplicate of this bug. *** Created attachment 183528 [details] [review] Bug 39951: Fix column filter offsets Test plan: 1) Enable ERM module 2) Create an agreement and a license with a vendor 3) The table filters will be out of sync - Agreements - only the vendor filter is incorrect, it sits above the name column instead of the vendor column - Licenses - all dropdown filter options will be left shifted by one 4) Apply patch 5) yarn js:build 6) Hard refresh the browser 7) All the filters should now be above the correct columns Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to main for 25.11 |