Bug 39951 - Column filters are offset in ERM
Summary: Column filters are offset in ERM
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Matt Blenkinsop
QA Contact: Jonathan Druart
URL:
Keywords: release-notes-needed
: 39950 40190 (view as bug list)
Depends on: 37273
Blocks:
  Show dependency treegraph
 
Reported: 2025-05-20 22:06 UTC by Roman Dolny
Modified: 2025-06-26 17:23 UTC (History)
7 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 39951: Fix column filter offsets (3.74 KB, patch)
2025-05-21 08:25 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 39951: Fix column filter offsets (2.68 KB, patch)
2025-05-22 08:21 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 39951: Fix column filter offsets (2.73 KB, patch)
2025-05-22 08:43 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 39951: Fix column filter offsets (2.80 KB, patch)
2025-06-26 07:47 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Dolny 2025-05-20 22:06:17 UTC
To reproduce:
1. Enable ERMModule.
2. Add Lincense (with vendor) and show table with licences.
3. Note no text input filter for column Name. There should be one.
4. Note that filters for columns Vendor, Description, Type, Status are left-shifted (dropdown list with vendors is in column Name, and so on). They should be moved one column right.
Comment 1 Matt Blenkinsop 2025-05-21 08:25:26 UTC
Created attachment 182686 [details] [review]
Bug 39951: Fix column filter offsets

Test plan:
1) Enable ERM module
2) Create an agreement and a license with a vendor
3) The table filters will be out of sync
- Agreements - only the vendor filter is incorrect, it sits above the name column instead of the vendor column
- Licenses - all dropdown filter options will be left shifted by one
4) Apply patch
5) yarn js:build
6) Hard refresh the browser
7) All the filters should now be above the correct columns
Comment 2 Matt Blenkinsop 2025-05-21 08:36:52 UTC
*** Bug 39950 has been marked as a duplicate of this bug. ***
Comment 3 Roman Dolny 2025-05-21 17:22:46 UTC
Thanks for patch, unfortunetely it doesn't apply.

kohadev-koha@kohadevbox:koha(bug_39951)$ git bz apply 39951

Bug 39951 - No filter for Name column in licenses table in ERM

182686 - Bug 39951: Fix column filter offsets

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 39951: Fix column filter offsets
Using index info to reconstruct a base tree...
M       koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue
M       koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue
Auto-merging koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue
error: Failed to merge in the changes.
Patch failed at 0001 Bug 39951: Fix column filter offsets
Comment 4 Matt Blenkinsop 2025-05-22 08:21:57 UTC
Created attachment 182720 [details] [review]
Bug 39951: Fix column filter offsets

Test plan:
1) Enable ERM module
2) Create an agreement and a license with a vendor
3) The table filters will be out of sync
- Agreements - only the vendor filter is incorrect, it sits above the name column instead of the vendor column
- Licenses - all dropdown filter options will be left shifted by one
4) Apply patch
5) yarn js:build
6) Hard refresh the browser
7) All the filters should now be above the correct columns
Comment 5 Roman Dolny 2025-05-22 08:43:21 UTC
Created attachment 182721 [details] [review]
Bug 39951: Fix column filter offsets

Test plan:
1) Enable ERM module
2) Create an agreement and a license with a vendor
3) The table filters will be out of sync
- Agreements - only the vendor filter is incorrect, it sits above the name column instead of the vendor column
- Licenses - all dropdown filter options will be left shifted by one
4) Apply patch
5) yarn js:build
6) Hard refresh the browser
7) All the filters should now be above the correct columns

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 6 Matt Blenkinsop 2025-06-24 09:41:47 UTC
*** Bug 40190 has been marked as a duplicate of this bug. ***
Comment 7 Jonathan Druart 2025-06-26 07:47:29 UTC
Created attachment 183528 [details] [review]
Bug 39951: Fix column filter offsets

Test plan:
1) Enable ERM module
2) Create an agreement and a license with a vendor
3) The table filters will be out of sync
- Agreements - only the vendor filter is incorrect, it sits above the name column instead of the vendor column
- Licenses - all dropdown filter options will be left shifted by one
4) Apply patch
5) yarn js:build
6) Hard refresh the browser
7) All the filters should now be above the correct columns

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Lucas Gass (lukeg) 2025-06-26 17:11:55 UTC
Nice work everyone!

Pushed to main for 25.11