Summary: | Report subgroup filter not cleared when changing tabs | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Reports | Assignee: | Owen Leonard <oleonard> |
Status: | Pushed to oldstable --- | QA Contact: | Emily Lamancusa (emlam) <emily.lamancusa> |
Severity: | normal | ||
Priority: | P5 - low | CC: | anneli.osterman, emily.lamancusa, fridolin.somers |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.11.00,25.05.01,24.11.06
|
Circulation function: | |
Bug Depends on: | |||
Bug Blocks: | 39534 | ||
Attachments: |
Bug 39955: Report subgroup filter not cleared when changing tabs
Bug 39955: Report subgroup filter not cleared when changing tabs Bug 39955: Report subgroup filter not cleared when changing tabs |
Description
Owen Leonard
2025-05-21 14:38:06 UTC
Created attachment 182695 [details] [review] Bug 39955: Report subgroup filter not cleared when changing tabs This patch fixes the JS on the saved SQL reports page so that the subgroup column filter is correctly cleared when the tab changes. The wrong table column is targeted. To test, apply the patch and go to Reports -> Saved SQL reports. - If necessary, at least two SQL reports, each with in a different group and different subgroup. For example: - sql: SELECT * FROM items LIMIT 10; - group: Catalog - subgroup: Statistics ...and... - sql: SELECT * FROM borrowers LIMIT 10; - group: Patrons - subgroup: Statistics - From the saved reports page, go to the tab for one of your reports and filter by subgroup. - Switch to a different tab containing SQL reports. The reports should be shown as expected. Sponsored-by: Athens County Public Libraries Created attachment 182715 [details] [review] Bug 39955: Report subgroup filter not cleared when changing tabs This patch fixes the JS on the saved SQL reports page so that the subgroup column filter is correctly cleared when the tab changes. The wrong table column is targeted. To test, apply the patch and go to Reports -> Saved SQL reports. - If necessary, at least two SQL reports, each with in a different group and different subgroup. For example: - sql: SELECT * FROM items LIMIT 10; - group: Catalog - subgroup: Statistics ...and... - sql: SELECT * FROM borrowers LIMIT 10; - group: Patrons - subgroup: Statistics - From the saved reports page, go to the tab for one of your reports and filter by subgroup. - Switch to a different tab containing SQL reports. The reports should be shown as expected. Sponsored-by: Athens County Public Libraries Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Created attachment 182850 [details] [review] Bug 39955: Report subgroup filter not cleared when changing tabs This patch fixes the JS on the saved SQL reports page so that the subgroup column filter is correctly cleared when the tab changes. The wrong table column is targeted. To test, apply the patch and go to Reports -> Saved SQL reports. - If necessary, at least two SQL reports, each with in a different group and different subgroup. For example: - sql: SELECT * FROM items LIMIT 10; - group: Catalog - subgroup: Statistics ...and... - sql: SELECT * FROM borrowers LIMIT 10; - group: Patrons - subgroup: Statistics - From the saved reports page, go to the tab for one of your reports and filter by subgroup. - Switch to a different tab containing SQL reports. The reports should be shown as expected. Sponsored-by: Athens County Public Libraries Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Nice work everyone! Pushed to main for 25.11 I see in 25.05.x Pushed to 24.11.x for 24.11.06 Nice work everyone! Pushed to 25.05.x for 25.05.03 |