There is an error in the way saved SQL report subgroups behave when you change tabs: The subgroup filter gets applied to the new tab too. Since subgroup codes are unique, this means the all the reports under the tab you switched to are filtered out.
Created attachment 182695 [details] [review] Bug 39955: Report subgroup filter not cleared when changing tabs This patch fixes the JS on the saved SQL reports page so that the subgroup column filter is correctly cleared when the tab changes. The wrong table column is targeted. To test, apply the patch and go to Reports -> Saved SQL reports. - If necessary, at least two SQL reports, each with in a different group and different subgroup. For example: - sql: SELECT * FROM items LIMIT 10; - group: Catalog - subgroup: Statistics ...and... - sql: SELECT * FROM borrowers LIMIT 10; - group: Patrons - subgroup: Statistics - From the saved reports page, go to the tab for one of your reports and filter by subgroup. - Switch to a different tab containing SQL reports. The reports should be shown as expected. Sponsored-by: Athens County Public Libraries
Created attachment 182715 [details] [review] Bug 39955: Report subgroup filter not cleared when changing tabs This patch fixes the JS on the saved SQL reports page so that the subgroup column filter is correctly cleared when the tab changes. The wrong table column is targeted. To test, apply the patch and go to Reports -> Saved SQL reports. - If necessary, at least two SQL reports, each with in a different group and different subgroup. For example: - sql: SELECT * FROM items LIMIT 10; - group: Catalog - subgroup: Statistics ...and... - sql: SELECT * FROM borrowers LIMIT 10; - group: Patrons - subgroup: Statistics - From the saved reports page, go to the tab for one of your reports and filter by subgroup. - Switch to a different tab containing SQL reports. The reports should be shown as expected. Sponsored-by: Athens County Public Libraries Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi>
Created attachment 182850 [details] [review] Bug 39955: Report subgroup filter not cleared when changing tabs This patch fixes the JS on the saved SQL reports page so that the subgroup column filter is correctly cleared when the tab changes. The wrong table column is targeted. To test, apply the patch and go to Reports -> Saved SQL reports. - If necessary, at least two SQL reports, each with in a different group and different subgroup. For example: - sql: SELECT * FROM items LIMIT 10; - group: Catalog - subgroup: Statistics ...and... - sql: SELECT * FROM borrowers LIMIT 10; - group: Patrons - subgroup: Statistics - From the saved reports page, go to the tab for one of your reports and filter by subgroup. - Switch to a different tab containing SQL reports. The reports should be shown as expected. Sponsored-by: Athens County Public Libraries Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Nice work everyone! Pushed to main for 25.11
I see in 25.05.x
Pushed to 24.11.x for 24.11.06
Nice work everyone! Pushed to 25.05.x for 25.05.03