Bug 39534 - Saved report subgroup filter not hidden correctly
Summary: Saved report subgroup filter not hidden correctly
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Lisette Scheer
URL:
Keywords: release-notes-needed
Depends on: 39955
Blocks:
  Show dependency treegraph
 
Reported: 2025-04-02 16:45 UTC by Owen Leonard
Modified: 2025-06-30 14:36 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 39534: Hide reports subgroup filter if there are no subgroups (2.99 KB, patch)
2025-05-21 17:08 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39534: Hide reports subgroup filter if there are no subgroups (3.14 KB, patch)
2025-05-22 09:54 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 39534: Hide reports subgroup filter if there are no subgroups (3.20 KB, patch)
2025-06-27 17:34 UTC, Lisette Scheer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2025-04-02 16:45:49 UTC
When viewing a tab on the saved reports page, a "subgroups" dropdown appears whether or not there are any subgroups for that group. The dropdown should be hidden if there are no subgroups.
Comment 1 Owen Leonard 2025-05-21 17:01:46 UTC
Bug 39534: Saved report subgroup filter not hidden correctly
Comment 2 Owen Leonard 2025-05-21 17:08:57 UTC Comment hidden (obsolete)
Comment 3 PTFS Europe Sandboxes 2025-05-22 09:54:38 UTC
Created attachment 182723 [details] [review]
Bug 39534: Hide reports subgroup filter if there are no subgroups

This patch updates the JavaScript which runs on the list of saved SQL
reports, adding a check for report subgroups to the display of the
report subgroups dropdown. The patch also hides the subgroups dropdown
if there is no saved tab, in which case the tabsInit function doesn't
run.

To test you should have multiple reports organized in multiple groups
and subgroups. See the test plan on Bug 39534.

- Go to Reports -> Saved SQL reports.
- If the page loads with the "All" tab active, there should be no
  subgroups dropdown.
- If the page loads under a different tab, the subgroups dropdown should
  only show if that group has subgroups.
- Switch between the various report group tabs to confirm that the
  subgroups dropdown is shown or hidden correctly based on the existence
  of subgroups.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi>
Comment 4 Lisette Scheer 2025-06-27 17:34:44 UTC
Created attachment 183624 [details] [review]
Bug 39534: Hide reports subgroup filter if there are no subgroups

This patch updates the JavaScript which runs on the list of saved SQL
reports, adding a check for report subgroups to the display of the
report subgroups dropdown. The patch also hides the subgroups dropdown
if there is no saved tab, in which case the tabsInit function doesn't
run.

To test you should have multiple reports organized in multiple groups
and subgroups. See the test plan on Bug 39534.

- Go to Reports -> Saved SQL reports.
- If the page loads with the "All" tab active, there should be no
  subgroups dropdown.
- If the page loads under a different tab, the subgroups dropdown should
  only show if that group has subgroups.
- Switch between the various report group tabs to confirm that the
  subgroups dropdown is shown or hidden correctly based on the existence
  of subgroups.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi>
Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 5 Lucas Gass (lukeg) 2025-06-30 14:32:17 UTC
Nice work everyone!

Pushed to main for 25.11