| Summary: | Warning generated when creating a new bib record | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | Needs documenting --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, m.de.rooy, wainuiwitikapark |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This removes an unnecessary warning from the logs when creating a new bibliographic record, and updates the tests.
|
Version(s) released in: |
25.11.00,25.05.01,24.11.08
|
| Circulation function: | |||
| Bug Depends on: | 37870 | ||
| Bug Blocks: | 25790 | ||
| Attachments: |
Bug 40003: Remove warning from log when creating a new bib record
Bug 40003: Add a test Bug 40003: Remove warning from log when creating a new bib record Bug 40003: Add a test Bug 40003: Remove warning from log when creating a new bib record Bug 40003: Add a test |
||
|
Description
Jonathan Druart
2025-05-27 08:39:08 UTC
Created attachment 182791 [details] [review] Bug 40003: Remove warning from log when creating a new bib record Test plan: Hit cataloguing/addbiblio.pl?frameworkcode=FA Without this patch you get warnings in the Koha log file: Use of uninitialized value in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 572. Use of uninitialized value in substitution (s///) at /kohadevbox/koha/Koha/UI/Form/Builder/Biblio.pm line 55. with this patch applied: no warning Created attachment 182792 [details] [review] Bug 40003: Add a test Created attachment 182794 [details] [review] Bug 40003: Remove warning from log when creating a new bib record Test plan: Hit cataloguing/addbiblio.pl?frameworkcode=FA Without this patch you get warnings in the Koha log file: Use of uninitialized value in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 572. Use of uninitialized value in substitution (s///) at /kohadevbox/koha/Koha/UI/Form/Builder/Biblio.pm line 55. with this patch applied: no warning Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 182795 [details] [review] Bug 40003: Add a test Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 183049 [details] [review] Bug 40003: Remove warning from log when creating a new bib record Test plan: Hit cataloguing/addbiblio.pl?frameworkcode=FA Without this patch you get warnings in the Koha log file: Use of uninitialized value in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 572. Use of uninitialized value in substitution (s///) at /kohadevbox/koha/Koha/UI/Form/Builder/Biblio.pm line 55. with this patch applied: no warning Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 183050 [details] [review] Bug 40003: Add a test Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x for 25.05.03 Pushed to 24.11.x for 24.11.08 Not backporting to 22.11.x as it wasn't backported to 24.05.x |