Bug 40003

Summary: Warning generated when creating a new bib record
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: Pushed to stable --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: minor    
Priority: P5 - low CC: david, m.de.rooy
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
This removes an unnecessary warning from the logs when creating a new bibliographic record, and updates the tests.
Version(s) released in:
25.11.00,25.05.01
Circulation function:
Bug Depends on: 37870    
Bug Blocks: 25790    
Attachments: Bug 40003: Remove warning from log when creating a new bib record
Bug 40003: Add a test
Bug 40003: Remove warning from log when creating a new bib record
Bug 40003: Add a test
Bug 40003: Remove warning from log when creating a new bib record
Bug 40003: Add a test

Description Jonathan Druart 2025-05-27 08:39:08 UTC
cataloguing/addbiblio.pl?frameworkcode=FA

Use of uninitialized value in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 572.                                                                                          
Use of uninitialized value in substitution (s///) at /kohadevbox/koha/Koha/UI/Form/Builder/Biblio.pm line 55.
Comment 1 Jonathan Druart 2025-05-27 08:41:50 UTC
Created attachment 182791 [details] [review]
Bug 40003: Remove warning from log when creating a new bib record

Test plan:
Hit cataloguing/addbiblio.pl?frameworkcode=FA

Without this patch you get warnings in the Koha log file:
Use of uninitialized value in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 572.
Use of uninitialized value in substitution (s///) at /kohadevbox/koha/Koha/UI/Form/Builder/Biblio.pm line 55.

with this patch applied: no warning
Comment 2 Jonathan Druart 2025-05-27 09:25:40 UTC
Created attachment 182792 [details] [review]
Bug 40003: Add a test
Comment 3 Owen Leonard 2025-05-27 12:17:08 UTC
Created attachment 182794 [details] [review]
Bug 40003: Remove warning from log when creating a new bib record

Test plan:
Hit cataloguing/addbiblio.pl?frameworkcode=FA

Without this patch you get warnings in the Koha log file:
Use of uninitialized value in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 572.
Use of uninitialized value in substitution (s///) at /kohadevbox/koha/Koha/UI/Form/Builder/Biblio.pm line 55.

with this patch applied: no warning

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Owen Leonard 2025-05-27 12:17:11 UTC
Created attachment 182795 [details] [review]
Bug 40003: Add a test

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Marcel de Rooy 2025-06-06 07:26:47 UTC
Created attachment 183049 [details] [review]
Bug 40003: Remove warning from log when creating a new bib record

Test plan:
Hit cataloguing/addbiblio.pl?frameworkcode=FA

Without this patch you get warnings in the Koha log file:
Use of uninitialized value in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 572.
Use of uninitialized value in substitution (s///) at /kohadevbox/koha/Koha/UI/Form/Builder/Biblio.pm line 55.

with this patch applied: no warning

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Marcel de Rooy 2025-06-06 07:26:51 UTC
Created attachment 183050 [details] [review]
Bug 40003: Add a test

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Lucas Gass (lukeg) 2025-06-06 15:44:31 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 8 Paul Derscheid 2025-06-22 21:47:09 UTC
Nice work everyone!

Pushed to 25.05.x for 25.05.03