| Summary: | Z39.50 search: Allow leader and specific control field positions in Additional fields | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Cataloging | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | Pushed to main --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | david, lucas, m.de.rooy, martin.renvoize, mirjam.vantieghem |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23017 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31726 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29885 |
||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This enhancement to the AdditionalFieldsInZ3950ResultSearch and AdditionalFieldsInZ3950ResultAuthSearch system preferences improves what you can show for the additional fields in the Z39.50 search results:
[1] the complete leader with 000
[2] the complete control field, for example 008
[3] specific positions in the leader or control fields, for example 000p1, 008p2, etc.
[4] a range from the leader or control field, for example 000p6-7, 008p35-37, etc.
|
Version(s) released in: |
25.11.00
|
| Circulation function: | |||
| Attachments: |
Bug 40017: Add leader and control field positions to Z3950 search results
Bug 40017: (follow-up) More rigorous checking Bug 40017: Add leader and control field positions to Z3950 search results Bug 40017: (follow-up) More rigorous checking Bug 40017: Add leader and control field positions to Z3950 search results Bug 40017: (follow-up) More rigorous checking Bug 40017: (follow-up) Update GNU license link Bug 40017: (QA follow-up) Fix t/db/Breeding.t |
||
Created attachment 182821 [details] [review] Bug 40017: Add leader and control field positions to Z3950 search results Test plan: Run t/Breeding.t Set AdditionalFieldsInZ3950ResultSearch to 000p6, 008, 040$b Do some searches and check the Additional fields column of results. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> After applying the patch, Z39.50/SRU searches return results only for the LIBRARY OF CONGRESS SRU search target. Any other search target returns a 500 error. Testing notes (using KTD, MARC21): 1. Before applying the patch: - Set AdditionalFieldsInZ3950ResultSearch = 000p6, 008p35-37, 040$b - Go to Cataloguing > New from Z39.50/SRU > Books, Booklets, Workbooks - In the title enter: dita - Note that in the additional fields column, some of the returned records have additional information - such as the full 008 or the value of 040$b (none of the search results had any 001 values) 2. After applying the patch, restart everything (restart_all) and clear your browser cache. 3. If you repeat step 1, I sometimes got results. But most often I got an Error 500 page. (Before the patch, I didn't get any). With the sample targets in KTD: - I was only ever able to get results when using LIBRARY OF CONGRESS SRU - If LIBRARY OF CONGRESS or NATIONAL LIBRARY OF FRANCE were selected, I always got a 500 error - Before the patch: any combination of search targets returned results 4. The /var/log/koha/kohadev/plack-intranet-error.log only contains warnings: lots of [WARN] Use of uninitialized value ... 5. The tests pass: prove t/Breeding.t (In reply to David Nind from comment #2) > After applying the patch, Z39.50/SRU searches return results only for the > LIBRARY OF CONGRESS SRU search target. Any other search target returns a 500 > error. Thats weird. I cant reproduce with the LOC server. The National Library of France times out with me. (What were your search fields and used terms.) For 500 errors, please check plack-error.log and extract the error description and the offending line from C4/Breeding from the trace. > 4. The /var/log/koha/kohadev/plack-intranet-error.log only contains > warnings: lots of [WARN] Use of uninitialized value ... Please copy distinct warnings when these refer to the Breeding module. Thanks. (In reply to Marcel de Rooy from comment #3) > Thats weird. I cant reproduce with the LOC server. The National Library of > France times out with me. (What were your search fields and used terms.) Wait. I can reproduce now while looking more closely to your test plan. An seemingly important difference is starting from Books, Booklets, .. Looking further. Created attachment 182902 [details] [review] Bug 40017: (follow-up) More rigorous checking Adding a few checks to resolve the errors David found while testing. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> David, the follow-up should take care of the errors you catched. Thanks. I got now results with the same pref value, for title=dita and targets LOC and France library. Created attachment 182939 [details] [review] Bug 40017: Add leader and control field positions to Z3950 search results Test plan: Run t/Breeding.t Set AdditionalFieldsInZ3950ResultSearch to 000p6, 008, 040$b Do some searches and check the Additional fields column of results. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Created attachment 182940 [details] [review] Bug 40017: (follow-up) More rigorous checking Adding a few checks to resolve the errors David found while testing. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> (In reply to Marcel de Rooy from comment #6) > David, the follow-up should take care of the errors you catched. Thanks. I > got now results with the same pref value, for title=dita and targets LOC and > France library. Thanks Marcel! (In reply to David Nind from comment #9) > (In reply to Marcel de Rooy from comment #6) > > David, the follow-up should take care of the errors you catched. Thanks. I > > got now results with the same pref value, for title=dita and targets LOC and > > France library. > > Thanks Marcel! U+1F44D Created attachment 187655 [details] [review] Bug 40017: Add leader and control field positions to Z3950 search results Test plan: Run t/Breeding.t Set AdditionalFieldsInZ3950ResultSearch to 000p6, 008, 040$b Do some searches and check the Additional fields column of results. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Created attachment 187656 [details] [review] Bug 40017: (follow-up) More rigorous checking Adding a few checks to resolve the errors David found while testing. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Created attachment 188295 [details] [review] Bug 40017: (follow-up) Update GNU license link Nice work everyone! Pushed to main for 25.11 t/db_dependent/Breeding.t is now failing. git bisects blames this bug. Marcel, can you check? (In reply to Lucas Gass (lukeg) from comment #15) > t/db_dependent/Breeding.t is now failing. git bisects blames this bug. > Marcel, can you check? Will check Created attachment 188398 [details] [review] Bug 40017: (QA follow-up) Fix t/db/Breeding.t Although t/Breeding.t was adjusted, the t/db counterpart should have been adjusted too. The sort order was added, the subfield tag was moved. Test plan: Run test again. Thanks Marcel, follow-up pushed to main! |
Would be nice to include things like 000p6-7 for position 6 and 7 of leader (field '000') 008p35-37 (pos 35-57, language) of 008 in the prefs for additional fields in Z39.50 search. AdditionalFieldsInZ3950ResultSearch AdditionalFieldsInZ3950ResultAuthSearch