Bug 40122

Summary: 'Holds to pull' library filters don't work if library name contains parenthesis
Product: Koha Reporter: Pedro Amorim <pedro.amorim>
Component: Hold requestsAssignee: Pedro Amorim <pedro.amorim>
Status: Pushed to oldstable --- QA Contact: Jonathan Druart <jonathan.druart>
Severity: normal    
Priority: P5 - low CC: david, fridolin.somers, gmcharlt, jonathan.druart, lucas, martin.renvoize, pedro.amorim
Version: MainKeywords: rel_24_11_candidate, rel_25_05_candidate
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40565
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
This fixes the holds to pull page so that the dropdown library filter works if the library name contains parenthesis (Circulation > Holds and bookings > Holds to pull).
Version(s) released in:
25.11.00,25.05.02,24.11.08
Circulation function:
Bug Depends on: 40118    
Bug Blocks:    
Attachments: Bug 40122: Dont attempt regex search for select dropdowns
Bug 40122: [24.11] Fix datatable select search if data has parenthesis
Bug 40122: [24.11] Dont attempt regex search for select dropdowns
Bug 40122: Dont attempt regex search for select dropdowns
Bug 40122: Dont attempt regex search for select dropdowns

Description Pedro Amorim 2025-06-11 15:50:59 UTC

    
Comment 1 Pedro Amorim 2025-06-11 15:56:22 UTC
Created attachment 183171 [details] [review]
Bug 40122: Dont attempt regex search for select dropdowns

Test plan:
1) Place a hold (next available) to biblio 76 and 437:
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=437
2) Edit 'Centerville' library name to 'Centerville (CPL)'
3) Visit the 'holds to pull' page:
http://localhost:8081/cgi-bin/koha/circ/pendingreserves.pl
4) Try to filter for 'Centerville (CPL)'. Notice the filtering returns nothing.
5) Apply patches. Repeat test plan. Notice 'Centerville (CPL)' filtering now works.
Comment 2 Pedro Amorim 2025-06-11 15:58:12 UTC Comment hidden (obsolete)
Comment 3 Pedro Amorim 2025-06-11 15:59:05 UTC
Created attachment 183173 [details] [review]
Bug 40122: [24.11] Dont attempt regex search for select dropdowns
Comment 4 David Nind 2025-06-13 08:16:35 UTC
Created attachment 183227 [details] [review]
Bug 40122: Dont attempt regex search for select dropdowns

Test plan:
1) Place a hold (next available) to biblio 76 and 437:
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=437
2) Edit 'Centerville' library name to 'Centerville (CPL)'
3) Visit the 'holds to pull' page:
http://localhost:8081/cgi-bin/koha/circ/pendingreserves.pl
4) Try to filter for 'Centerville (CPL)'. Notice the filtering returns nothing.
5) Apply patches. Repeat test plan. Notice 'Centerville (CPL)' filtering now works.
Comment 5 Paul Derscheid 2025-06-18 07:54:26 UTC
Created attachment 183319 [details] [review]
Bug 40122: Dont attempt regex search for select dropdowns

Test plan:
1) Place a hold (next available) to biblio 76 and 437:
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=437
2) Edit 'Centerville' library name to 'Centerville (CPL)'
3) Visit the 'holds to pull' page:
http://localhost:8081/cgi-bin/koha/circ/pendingreserves.pl
4) Try to filter for 'Centerville (CPL)'. Notice the filtering returns nothing.
5) Apply patches. Repeat test plan. Notice 'Centerville (CPL)' filtering now works.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 6 Jonathan Druart 2025-06-19 14:18:57 UTC
We need a Cypress test, ideally on top of bug 40180. I can write it as soon as it is pushed.
Comment 7 Lucas Gass (lukeg) 2025-06-23 15:59:20 UTC
Setting to BLOCKED until conflict with Bug 40118 can be resolved.
Comment 8 Lucas Gass (lukeg) 2025-06-24 13:52:48 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 9 Paul Derscheid 2025-07-09 11:43:25 UTC
Nice work everyone!

Pushed to 25.05.x for 25.05.01
Comment 10 Fridolin Somers 2025-07-25 13:28:08 UTC
Pushed to 24.11.x for 24.11.08