Bug 40122 - 'Holds to pull' library filters don't work if library name contains parenthesis
Summary: 'Holds to pull' library filters don't work if library name contains parenthesis
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Pedro Amorim
QA Contact: Jonathan Druart
URL:
Keywords: rel_24_11_candidate, rel_25_05_candidate
Depends on: 40118
Blocks:
  Show dependency treegraph
 
Reported: 2025-06-11 15:50 UTC by Pedro Amorim
Modified: 2025-06-19 14:18 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40122: Dont attempt regex search for select dropdowns (2.02 KB, patch)
2025-06-11 15:56 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 40122: [24.11] Fix datatable select search if data has parenthesis (1.50 KB, patch)
2025-06-11 15:58 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 40122: [24.11] Dont attempt regex search for select dropdowns (1.50 KB, patch)
2025-06-11 15:59 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 40122: Dont attempt regex search for select dropdowns (2.02 KB, patch)
2025-06-13 08:16 UTC, David Nind
Details | Diff | Splinter Review
Bug 40122: Dont attempt regex search for select dropdowns (2.12 KB, patch)
2025-06-18 07:54 UTC, Paul Derscheid
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2025-06-11 15:50:59 UTC

    
Comment 1 Pedro Amorim 2025-06-11 15:56:22 UTC
Created attachment 183171 [details] [review]
Bug 40122: Dont attempt regex search for select dropdowns

Test plan:
1) Place a hold (next available) to biblio 76 and 437:
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=437
2) Edit 'Centerville' library name to 'Centerville (CPL)'
3) Visit the 'holds to pull' page:
http://localhost:8081/cgi-bin/koha/circ/pendingreserves.pl
4) Try to filter for 'Centerville (CPL)'. Notice the filtering returns nothing.
5) Apply patches. Repeat test plan. Notice 'Centerville (CPL)' filtering now works.
Comment 2 Pedro Amorim 2025-06-11 15:58:12 UTC Comment hidden (obsolete)
Comment 3 Pedro Amorim 2025-06-11 15:59:05 UTC
Created attachment 183173 [details] [review]
Bug 40122: [24.11] Dont attempt regex search for select dropdowns
Comment 4 David Nind 2025-06-13 08:16:35 UTC
Created attachment 183227 [details] [review]
Bug 40122: Dont attempt regex search for select dropdowns

Test plan:
1) Place a hold (next available) to biblio 76 and 437:
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=437
2) Edit 'Centerville' library name to 'Centerville (CPL)'
3) Visit the 'holds to pull' page:
http://localhost:8081/cgi-bin/koha/circ/pendingreserves.pl
4) Try to filter for 'Centerville (CPL)'. Notice the filtering returns nothing.
5) Apply patches. Repeat test plan. Notice 'Centerville (CPL)' filtering now works.
Comment 5 Paul Derscheid 2025-06-18 07:54:26 UTC
Created attachment 183319 [details] [review]
Bug 40122: Dont attempt regex search for select dropdowns

Test plan:
1) Place a hold (next available) to biblio 76 and 437:
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=437
2) Edit 'Centerville' library name to 'Centerville (CPL)'
3) Visit the 'holds to pull' page:
http://localhost:8081/cgi-bin/koha/circ/pendingreserves.pl
4) Try to filter for 'Centerville (CPL)'. Notice the filtering returns nothing.
5) Apply patches. Repeat test plan. Notice 'Centerville (CPL)' filtering now works.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 6 Jonathan Druart 2025-06-19 14:18:57 UTC
We need a Cypress test, ideally on top of bug 40180. I can write it as soon as it is pushed.